Commit 68f4ca7 issues

[Guus Sliepen]

On Fri, Apr 08, 2016 at 12:29:27PM +0200, borg at uu3.net wrote:

> I have issues building tincd-1.0.26 on FreeBSD 4.11

While I do like to make things backwards compatible, tinc 1.0.26 is from
2015, and FreeBSD 4.11 is from 2005. Is there a reason you're sticking
to 4.11, and/or do you have the same issue with a newer version of
FreeBSD, like 10.3?

> Seems commit 68f4ca711593416d0defd81199b176ba604c6cb1
> that "modernizes" build system was a bad idea after all?
> Not sure why merging lib/ to src/ was done.

It was done because in reality, there is no library, it was just an
arbitrary split of source files into two directories. Putting it all
into one removed this split and made things like link-time optimization
possible.

> Most software I see contains directories like compat/
> to aid building for older or broken environments..
> This makes clear difference between software sources
> itself (src) and compatibility additions (compat).

The compatibility functions (from fake-*.c and dropin.c) are still
there, they just moved into src/.

> As for FreeBSD itself, I had to change include from global
> to local:
> 
> #include "getopt.h"

What do you mean by that exactly? If you could send a diff of your
changes, I can see if they can be merged.

-- 
Met vriendelijke groet / with kind regards,
     Guus Sliepen <guus at tinc-vpn.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://www.tinc-vpn.org/pipermail/tinc-devel/attachments/20160408/234cff3c/attachment.sig>