Commit 68f4ca7 issues

[borg at uu3.net]

There are few reasons why I stick to older OSes.
In case of FreeBSD its my customized Imunes platform
for network simulations...

Anyway, back to root problem:
gcc -std=gnu99 -DHAVE_CONFIG_H   -DCONFDIR=\"/etc\" -DLOCALSTATEDIR=\"/var\" 
-DFORTIFY_SOURCE=2  -g -O2 -MT tincd.o -MD -MP -MF $depbase.Tpo -c -o tincd.o 
tincd.c &&\
mv -f $depbase.Tpo $depbase.Po
tincd.c:52:20: getopt.h: No such file or directory
tincd.c:102: error: elements of array `long_options' have incomplete type

Im not very familiar with all those newer fancy build systems (deps tracking),
but for some reason getopt.h is not picked up from src directory at all

--- tincd.c.orig        Fri Apr  8 11:48:11 2016
+++ tincd.c     Fri Apr  8 11:48:29 2016
@@ -49,7 +49,7 @@
 #include <time.h>
 #endif

-#include <getopt.h>
+#include "getopt.h"
 #include "pidfile.h"

 #include "conf.h"

Of course this change cannot be implemented, because it will break
all other systems. If this can be easly fixed, then please do it.
If not, no problem... as this is trival to fix it by hand (for now...)

Kind regards,
Borg

---------- Original message ----------

From: Guus Sliepen <guus at tinc-vpn.org>
To: tinc-devel at tinc-vpn.org
Subject: Re: Commit 68f4ca7 issues
Date: Fri, 8 Apr 2016 13:26:57 +0200
Message-ID: <20160408112657.GF3784 at sliepen.org>

On Fri, Apr 08, 2016 at 12:29:27PM +0200, borg at uu3.net wrote:

> I have issues building tincd-1.0.26 on FreeBSD 4.11

While I do like to make things backwards compatible, tinc 1.0.26 is from
2015, and FreeBSD 4.11 is from 2005. Is there a reason you're sticking
to 4.11, and/or do you have the same issue with a newer version of
FreeBSD, like 10.3?

> Seems commit 68f4ca711593416d0defd81199b176ba604c6cb1
> that "modernizes" build system was a bad idea after all?
> Not sure why merging lib/ to src/ was done.

It was done because in reality, there is no library, it was just an
arbitrary split of source files into two directories. Putting it all
into one removed this split and made things like link-time optimization
possible.

> Most software I see contains directories like compat/
> to aid building for older or broken environments..
> This makes clear difference between software sources
> itself (src) and compatibility additions (compat).

The compatibility functions (from fake-*.c and dropin.c) are still
there, they just moved into src/.

> As for FreeBSD itself, I had to change include from global
> to local:
> 
> #include "getopt.h"

What do you mean by that exactly? If you could send a diff of your
changes, I can see if they can be merged.

-- 
Met vriendelijke groet / with kind regards,
     Guus Sliepen <guus at tinc-vpn.org>