[PATCH] Maintain outgoing TCP meta buffer

[Guus Sliepen]

On Wed, Jan 18, 2006 at 07:40:25PM -0800, Scott Lamb wrote:

> >I don't want to change the meaning of already existing configuration
> >variables.
> 
> Well, I'd like to split the meaning of PingTimeout into two:
> 
> * how often to send pings
> * how long to wait for responses
[...]
> My first patch kept PingTimeout meaning the first one; my second  
> patch kept it meaning the other. Would you prefer to introduce two  
> new options? I suppose it could issue a warning if the old one and  
> either/both of the new ones are specified. So "PingTimeout" would  
> give both. "PingInterval" would be the first only; "PongTimeout" or  
> maybe "PingResponseTimeout" would be the second. I like the way of my  
> second patch, but I'll go with whatever you prefer.

I guess I prefer the way of the latest patch.

> >Also, I still think it is better to put a limit to the size
> >of the buffer, and drop PACKETs when the buffer is larger than that
> >limit. Late packets rarely do any good anyway, best to get rid of  
> >them.
> 
> Sure. That's not hard, and you're probably right. But I'd like it to  
> be in addition to the ping changes, not instead of them.

I applied your patch (with only very minor changes), and added a
configurable limit to the size the output buffer can be before
send_tcppacket() drops packets.

-- 
Met vriendelijke groet / with kind regards,
    Guus Sliepen <guus at sliepen.eu.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://brouwer.uvt.nl/pipermail/tinc-devel/attachments/20060119/51bac881/attachment.pgp