Patch for tunnelserver mode in protocol_subnet.c

Thomas NOEL thomas.noel at auf.org
Wed Apr 13 15:25:05 CEST 2005


Hello,

Le 13.04.2005 15:08, Guus Sliepen a écrit :
>>- in tunnelserver mode, tinc must check subnets in the ".../hosts/owner"
>>  config file, not in "c->config_tree" (which is the configuration
>>  of the meta-connection from which we receive the ADD_SUBNET message).
> But these two are the same, because:
> 	if(tunnelserver && owner != myself && owner != c->node)
> 		return false;

Ooopps... Sorry...

>>- this checking can be made before the check of the owner, especially
>>  before any "new_node" call.
> I agree with that.

Me too ;)

Another question about tunnelserver : I see a lot of lines like these :

  	if(tunnelserver && owner != myself && owner != c->node)
  		return false;

But with a "return false" the meta-connection will be closed. Wouldn't 
it be better to answer "true" ? I.e. don't handle the request, but dont' 
close the connection ?

Thanks,
-- 
Thomas


More information about the tinc-devel mailing list