From 958a751e20270da821fee651ff9ecda8a2afc5d0 Mon Sep 17 00:00:00 2001 From: thorkill Date: Thu, 4 May 2017 23:44:56 +0200 Subject: [PATCH] Fix NULL pointer dereference in send_udp_info --- src/protocol_misc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/protocol_misc.c b/src/protocol_misc.c index 95bd322e..5bbdc6c7 100644 --- a/src/protocol_misc.c +++ b/src/protocol_misc.c @@ -194,6 +194,11 @@ bool send_udp_info(node_t *from, node_t *to) { farther than the static relay. */ to = (to->via == myself) ? to->nexthop : to->via; + if (to == NULL) { + logger(DEBUG_ALWAYS, LOG_ERR, "Something went wrong when selecting relay - possible fake UDP_INFO"); + return false; + } + /* Skip cases where sending UDP info messages doesn't make sense. This is done here in order to avoid repeating the same logic in multiple callsites. */ -- 2.20.1