From 633b7cbb452ea19e515cadee9bc63e631f8183c2 Mon Sep 17 00:00:00 2001 From: Etienne Dechamps Date: Sat, 13 Jul 2013 23:34:42 +0100 Subject: [PATCH] Fix combination of Mode = router and DeviceType = tap on Linux. I believe I have found a bug in tinc on Linux when it is used with Mode = router and DeviceType = tap. This combination is useful because it allows global broadcast packets to be used in router mode. However, when tinc receives a packet in this situation, it needs to make sure its destination MAC address matches the address of the TAP adapter, which is typically not the case since the sending node doesn't know the MAC address of the recipient. Unfortunately, this is not the case on Linux, which breaks connectivity. --- src/linux/device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/linux/device.c b/src/linux/device.c index 3b3b439d..127e3e82 100644 --- a/src/linux/device.c +++ b/src/linux/device.c @@ -84,6 +84,8 @@ static bool setup_device(void) { device_type = DEVICE_TYPE_TUN; device_info = "Linux tun/tap device (tun mode)"; } else { + if (routing_mode == RMODE_ROUTER) + overwrite_mac = true; ifr.ifr_flags = IFF_TAP | IFF_NO_PI; device_type = DEVICE_TYPE_TAP; device_info = "Linux tun/tap device (tap mode)"; -- 2.20.1