From: Maximilian Stein <m@steiny.biz>
Date: Mon, 15 Jan 2018 23:45:38 +0000 (+0100)
Subject: Fix SEGFAULT when trying to connect to IPv6 peer in non-IPv6 environment
X-Git-Tag: release-1.0.34~3
X-Git-Url: https://www.tinc-vpn.org/git/browse?p=tinc;a=commitdiff_plain;h=d2732abcc7ab0b10577c4eeedb2135d8f5f6b4d5;hp=92afeec172f1f8a9f8b0bfdb94311bf0405433bb

Fix SEGFAULT when trying to connect to IPv6 peer in non-IPv6 environment

Using my tinc setup I observe spurious SEGFAULTs in the daemon process.

My configuration comprises a proxy (type exec) and the peer's address is
given by its domain name. The domain resolves to both IPv4 and IPv6.
As IPv6 is not working in my environment, all connection attempts to the
resolved IPv6 addresses fail. Sometimes, after such a failure, the
segfault occurs.

Apparently, the issue is caused by a use after free due to failing to
reset a pointer.
---

diff --git a/src/net.c b/src/net.c
index 4b64492d..1fecd88f 100644
--- a/src/net.c
+++ b/src/net.c
@@ -218,6 +218,7 @@ void terminate_connection(connection_t *c, bool report) {
 		}
 
 		edge_del(c->edge);
+		c->edge = NULL;
 
 		/* Run MST and SSSP algorithms */