From: Guus Sliepen <guus@tinc-vpn.org>
Date: Mon, 6 Nov 2017 21:44:12 +0000 (+0100)
Subject: Const correctness.
X-Git-Tag: release-1.1pre16~52
X-Git-Url: https://www.tinc-vpn.org/git/browse?p=tinc;a=commitdiff_plain;h=38489e37f50e807e51bfd28ebb8b20396eed1447

Const correctness.
---

diff --git a/src/bsd/device.c b/src/bsd/device.c
index 6d68bc78..5a572ba3 100644
--- a/src/bsd/device.c
+++ b/src/bsd/device.c
@@ -56,7 +56,7 @@ typedef enum device_type {
 int device_fd = -1;
 char *device = NULL;
 char *iface = NULL;
-static char *device_info = NULL;
+static const char *device_info = "OS X utun device";
 #if defined(ENABLE_TUNEMU)
 static device_type_t device_type = DEVICE_TYPE_TUNEMU;
 #elif defined(HAVE_OPENBSD) || defined(HAVE_FREEBSD) || defined(HAVE_DRAGONFLY)
@@ -116,8 +116,6 @@ static bool setup_utun(void) {
 		iface = xstrdup(name);
 	}
 
-	device_info = "OS X utun device";
-
 	logger(DEBUG_ALWAYS, LOG_INFO, "%s is a %s", device, device_info);
 
 	return true;
diff --git a/src/cygwin/device.c b/src/cygwin/device.c
index 1265f9d5..6d94988e 100644
--- a/src/cygwin/device.c
+++ b/src/cygwin/device.c
@@ -38,7 +38,7 @@ int device_fd = -1;
 static HANDLE device_handle = INVALID_HANDLE_VALUE;
 char *device = NULL;
 char *iface = NULL;
-static char *device_info = NULL;
+static const char *device_info = "Windows tap device";
 
 static pid_t reader_pid;
 static int sp[2];
@@ -219,8 +219,6 @@ static bool setup_device(void) {
 		return false;
 	}
 
-	device_info = "Windows tap device";
-
 	logger(DEBUG_ALWAYS, LOG_INFO, "%s (%s) is a %s", device, iface, device_info);
 
 	return true;
diff --git a/src/dummy_device.c b/src/dummy_device.c
index c43d5862..80232e1e 100644
--- a/src/dummy_device.c
+++ b/src/dummy_device.c
@@ -22,12 +22,13 @@
 #include "device.h"
 #include "logger.h"
 #include "net.h"
+#include "xalloc.h"
 
-static char *device_info = "dummy device";
+static const char *device_info = "dummy device";
 
 static bool setup_device(void) {
-	device = "dummy";
-	iface = "dummy";
+	device = xstrdup("dummy");
+	iface = xstrdup("dummy");
 	logger(DEBUG_ALWAYS, LOG_INFO, "%s (%s) is a %s", device, iface, device_info);
 	return true;
 }
diff --git a/src/linux/device.c b/src/linux/device.c
index 23178a36..54ea5dca 100644
--- a/src/linux/device.c
+++ b/src/linux/device.c
@@ -44,7 +44,7 @@ char *device = NULL;
 char *iface = NULL;
 static char *type = NULL;
 static char ifrname[IFNAMSIZ];
-static char *device_info;
+static const char *device_info;
 
 static bool setup_device(void) {
 	if(!get_config_string(lookup_config(config_tree, "Device"), &device)) {
diff --git a/src/mingw/device.c b/src/mingw/device.c
index 1116b5e1..49d0cd34 100644
--- a/src/mingw/device.c
+++ b/src/mingw/device.c
@@ -43,7 +43,7 @@ static vpn_packet_t device_read_packet;
 static vpn_packet_t device_write_packet;
 char *device = NULL;
 char *iface = NULL;
-static char *device_info = NULL;
+static const char *device_info = "Windows tap device";
 
 extern char *myport;
 
diff --git a/src/multicast_device.c b/src/multicast_device.c
index c19852bf..99f26ca9 100644
--- a/src/multicast_device.c
+++ b/src/multicast_device.c
@@ -29,7 +29,7 @@
 #include "route.h"
 #include "xalloc.h"
 
-static char *device_info;
+static const char *device_info = "multicast socket";
 
 static struct addrinfo *ai = NULL;
 static mac_t ignore_src = {{0}};
@@ -40,8 +40,6 @@ static bool setup_device(void) {
 	char *space;
 	int ttl = 1;
 
-	device_info = "multicast socket";
-
 	get_config_string(lookup_config(config_tree, "Interface"), &iface);
 
 	if(!get_config_string(lookup_config(config_tree, "Device"), &device)) {
diff --git a/src/raw_socket_device.c b/src/raw_socket_device.c
index 0ac970cf..3ec8e571 100644
--- a/src/raw_socket_device.c
+++ b/src/raw_socket_device.c
@@ -33,7 +33,7 @@
 #include "xalloc.h"
 
 #if defined(PF_PACKET) && defined(ETH_P_ALL) && defined(AF_PACKET) && defined(SIOCGIFINDEX)
-static char *device_info;
+static const char *device_info = "raw_socket";
 
 static bool setup_device(void) {
 	struct ifreq ifr;
@@ -47,8 +47,6 @@ static bool setup_device(void) {
 		device = xstrdup(iface);
 	}
 
-	device_info = "raw socket";
-
 	if((device_fd = socket(PF_PACKET, SOCK_RAW, htons(ETH_P_ALL))) < 0) {
 		logger(DEBUG_ALWAYS, LOG_ERR, "Could not open %s: %s", device_info,
 		       strerror(errno));
diff --git a/src/solaris/device.c b/src/solaris/device.c
index 9480ddab..f27954b1 100644
--- a/src/solaris/device.c
+++ b/src/solaris/device.c
@@ -53,7 +53,7 @@ int device_fd = -1;
 static int ip_fd = -1;
 char *device = NULL;
 char *iface = NULL;
-static char *device_info = NULL;
+static const char *device_info = NULL;
 
 static bool setup_device(void) {
 	char *type;
diff --git a/src/uml_device.c b/src/uml_device.c
index 3f521040..dbb13e93 100644
--- a/src/uml_device.c
+++ b/src/uml_device.c
@@ -36,7 +36,7 @@ static int request_fd = -1;
 static int data_fd = -1;
 static int write_fd = -1;
 static int state = 0;
-static char *device_info;
+static const char *device_info = "UML network socket";
 
 enum request_type { REQ_NEW_CONTROL };
 
@@ -65,8 +65,6 @@ static bool setup_device(void) {
 
 	get_config_string(lookup_config(config_tree, "Interface"), &iface);
 
-	device_info = "UML network socket";
-
 	if((write_fd = socket(PF_UNIX, SOCK_DGRAM, 0)) < 0) {
 		logger(DEBUG_ALWAYS, LOG_ERR, "Could not open write %s: %s", device_info, strerror(errno));
 		event_exit();
diff --git a/src/vde_device.c b/src/vde_device.c
index 4cbf7128..0170af32 100644
--- a/src/vde_device.c
+++ b/src/vde_device.c
@@ -34,7 +34,7 @@ static struct vdepluglib plug;
 static struct vdeconn *conn = NULL;
 static int port = 0;
 static char *group = NULL;
-static char *device_info;
+static const char *device_info = "VDE socket";
 
 static bool setup_device(void) {
 	libvdeplug_dynopen(plug);
@@ -54,8 +54,6 @@ static bool setup_device(void) {
 
 	get_config_string(lookup_config(config_tree, "VDEGroup"), &group);
 
-	device_info = "VDE socket";
-
 	struct vde_open_args args = {
 		.port = port,
 		.group = group,