X-Git-Url: https://www.tinc-vpn.org/git/browse?p=tinc;a=blobdiff_plain;f=src%2Fprotocol_misc.c;h=22b204d9f2f3dcaabef9ab521e5418cf058ff383;hp=6f7ab03b3fc7ae5549717be54457a2ec727286ca;hb=2116c6eb7d328c7aa3ce3da54f95367e5199d373;hpb=6d08eb1614b59d5f86a43edda9db06fca72b76cd

diff --git a/src/protocol_misc.c b/src/protocol_misc.c
index 6f7ab03b..22b204d9 100644
--- a/src/protocol_misc.c
+++ b/src/protocol_misc.c
@@ -1,7 +1,7 @@
 /*
     protocol_misc.c -- handle the meta-protocol, miscellaneous functions
     Copyright (C) 1999-2005 Ivo Timmermans,
-                  2000-2009 Guus Sliepen <guus@tinc-vpn.org>
+                  2000-2012 Guus Sliepen <guus@tinc-vpn.org>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
@@ -34,8 +34,9 @@ int maxoutbufsize = 0;
 /* Status and error notification routines */
 
 bool send_status(connection_t *c, int statusno, const char *statusstring) {
-	if(!statusstring)
+	if(!statusstring) {
 		statusstring = "Status";
+	}
 
 	return send_request(c, "%d %d %s", STATUS, statusno, statusstring);
 }
@@ -46,19 +47,20 @@ bool status_h(connection_t *c) {
 
 	if(sscanf(c->buffer, "%*d %d " MAX_STRING, &statusno, statusstring) != 2) {
 		logger(LOG_ERR, "Got bad %s from %s (%s)", "STATUS",
-			   c->name, c->hostname);
+		       c->name, c->hostname);
 		return false;
 	}
 
 	ifdebug(STATUS) logger(LOG_NOTICE, "Status message from %s (%s): %d: %s",
-			   c->name, c->hostname, statusno, statusstring);
+	                       c->name, c->hostname, statusno, statusstring);
 
 	return true;
 }
 
 bool send_error(connection_t *c, int err, const char *errstring) {
-	if(!errstring)
+	if(!errstring) {
 		errstring = "Error";
+	}
 
 	return send_request(c, "%d %d %s", ERROR, err, errstring);
 }
@@ -69,12 +71,12 @@ bool error_h(connection_t *c) {
 
 	if(sscanf(c->buffer, "%*d %d " MAX_STRING, &err, errorstring) != 2) {
 		logger(LOG_ERR, "Got bad %s from %s (%s)", "ERROR",
-			   c->name, c->hostname);
+		       c->name, c->hostname);
 		return false;
 	}
 
 	ifdebug(ERROR) logger(LOG_NOTICE, "Error message from %s (%s): %d: %s",
-			   c->name, c->hostname, err, errorstring);
+	                      c->name, c->hostname, err, errorstring);
 
 	terminate_connection(c, c->status.active);
 
@@ -111,8 +113,17 @@ bool pong_h(connection_t *c) {
 
 	/* Succesful connection, reset timeout if this is an outgoing connection. */
 
-	if(c->outgoing)
+	if(c->outgoing) {
 		c->outgoing->timeout = 0;
+		c->outgoing->cfg = NULL;
+
+		if(c->outgoing->ai) {
+			freeaddrinfo(c->outgoing->ai);
+		}
+
+		c->outgoing->ai = NULL;
+		c->outgoing->aip = NULL;
+	}
 
 	return true;
 }
@@ -121,23 +132,25 @@ bool pong_h(connection_t *c) {
 
 bool send_tcppacket(connection_t *c, const vpn_packet_t *packet) {
 	/* If there already is a lot of data in the outbuf buffer, discard this packet.
-           We use a very simple Random Early Drop algorithm. */
+	   We use a very simple Random Early Drop algorithm. */
 
-	if(2.0 * c->outbuflen / (float)maxoutbufsize - 1 > (float)rand()/(float)RAND_MAX)
+	if(2.0 * c->outbuflen / (float)maxoutbufsize - 1 > (float)rand() / (float)RAND_MAX) {
 		return true;
+	}
 
-	if(!send_request(c, "%d %hd", PACKET, packet->len))
+	if(!send_request(c, "%d %hd", PACKET, packet->len)) {
 		return false;
+	}
 
-	return send_meta(c, (char *)packet->data, packet->len);
+	return send_meta(c, (char *)packet->data, packet->len) && flush_meta(c);
 }
 
 bool tcppacket_h(connection_t *c) {
-	short int len;
+	length_t len;
 
-	if(sscanf(c->buffer, "%*d %hd", &len) != 1) {
+	if(sscanf(c->buffer, "%*d %hu", &len) != 1) {
 		logger(LOG_ERR, "Got bad %s from %s (%s)", "PACKET", c->name,
-			   c->hostname);
+		       c->hostname);
 		return false;
 	}