X-Git-Url: https://www.tinc-vpn.org/git/browse?p=tinc;a=blobdiff_plain;f=src%2Fprotocol_key.c;h=8517411824cd08c1cb7f4580acf67e226464acf0;hp=d9719ca49df40c06b58d2628190a4348edc76ece;hb=a227843b739d279b63adcf3736ebb03d856080c4;hpb=e012e752f4f1a2b06dfab4640bbbea8f084999ff diff --git a/src/protocol_key.c b/src/protocol_key.c index d9719ca4..85174118 100644 --- a/src/protocol_key.c +++ b/src/protocol_key.c @@ -13,11 +13,9 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. - You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. - - $Id$ + You should have received a copy of the GNU General Public License along + with this program; if not, write to the Free Software Foundation, Inc., + 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include "system.h" @@ -38,10 +36,7 @@ bool mykeyused = false; -bool send_key_changed() -{ - cp(); - +bool send_key_changed() { /* Only send this message if some other daemon requested our key previously. This reduces unnecessary key_changed broadcasts. */ @@ -49,16 +44,13 @@ bool send_key_changed() if(!mykeyused) return true; - return send_request(broadcast, "%d %lx %s", KEY_CHANGED, random(), myself->name); + return send_request(broadcast, "%d %x %s", KEY_CHANGED, rand(), myself->name); } -bool key_changed_h(connection_t *c) -{ +bool key_changed_h(connection_t *c) { char name[MAX_STRING_SIZE]; node_t *n; - cp(); - if(sscanf(c->buffer, "%*d %*x " MAX_STRING, name) != 1) { logger(LOG_ERR, _("Got bad %s from %s (%s)"), "KEY_CHANGED", c->name, c->hostname); @@ -87,21 +79,15 @@ bool key_changed_h(connection_t *c) return true; } -bool send_req_key(node_t *to) -{ - cp(); - +bool send_req_key(node_t *to) { return send_request(to->nexthop->connection, "%d %s %s", REQ_KEY, myself->name, to->name); } -bool req_key_h(connection_t *c) -{ +bool req_key_h(connection_t *c) { char from_name[MAX_STRING_SIZE]; char to_name[MAX_STRING_SIZE]; node_t *from, *to; - cp(); - if(sscanf(c->buffer, "%*d " MAX_STRING " " MAX_STRING, from_name, to_name) != 2) { logger(LOG_ERR, _("Got bad %s from %s (%s)"), "REQ_KEY", c->name, c->hostname); @@ -144,16 +130,14 @@ bool req_key_h(connection_t *c) return true; } -bool send_ans_key(node_t *to) -{ +bool send_ans_key(node_t *to) { char *key; - cp(); - // Set key parameters to->incipher = myself->incipher; to->inkeylength = myself->inkeylength; to->indigest = myself->indigest; + to->inmaclength = myself->inmaclength; to->incompression = myself->incompression; // Allocate memory for key @@ -172,7 +156,7 @@ bool send_ans_key(node_t *to) // Convert to hexadecimal and send key = alloca(2 * to->inkeylength + 1); bin2hex(to->inkey, key, to->inkeylength); - key[to->outkeylength * 2] = '\0'; + key[to->inkeylength * 2] = '\0'; return send_request(to->nexthop->connection, "%d %s %s %s %d %d %d %d", ANS_KEY, myself->name, to->name, key, @@ -181,16 +165,13 @@ bool send_ans_key(node_t *to) to->incompression); } -bool ans_key_h(connection_t *c) -{ +bool ans_key_h(connection_t *c) { char from_name[MAX_STRING_SIZE]; char to_name[MAX_STRING_SIZE]; char key[MAX_STRING_SIZE]; int cipher, digest, maclength, compression; node_t *from, *to; - cp(); - if(sscanf(c->buffer, "%*d "MAX_STRING" "MAX_STRING" "MAX_STRING" %d %d %d %d", from_name, to_name, key, &cipher, &digest, &maclength, &compression) != 7) {