X-Git-Url: https://www.tinc-vpn.org/git/browse?p=tinc;a=blobdiff_plain;f=src%2Fconf.c;h=58d7b6d30e94b4975aa016ed697bf39340bcdfd7;hp=4497b0e13ac12990dbb15335ac1916db9267687e;hb=26203e250433b846118be1b2e236bf2541aa260d;hpb=ac1c0f6f66c727113b7a1703c639b54581618fe9 diff --git a/src/conf.c b/src/conf.c index 4497b0e1..58d7b6d3 100644 --- a/src/conf.c +++ b/src/conf.c @@ -81,18 +81,9 @@ config_t *new_config(void) { } void free_config(config_t *cfg) { - if(cfg->variable) { - free(cfg->variable); - } - - if(cfg->value) { - free(cfg->value); - } - - if(cfg->file) { - free(cfg->file); - } - + free(cfg->variable); + free(cfg->value); + free(cfg->file); free(cfg); } @@ -204,7 +195,7 @@ bool get_config_address(const config_t *cfg, struct addrinfo **result) { } bool get_config_subnet(const config_t *cfg, subnet_t **result) { - subnet_t subnet = {}; + subnet_t subnet = {0}; if(!cfg) { return false; @@ -432,7 +423,7 @@ bool read_server_config(void) { // And we try to read the ones that end with ".conf" if(l > 5 && !strcmp(".conf", & ep->d_name[ l - 5 ])) { - if(snprintf(fname, sizeof(fname), "%s/%s", dname, ep->d_name) >= sizeof(fname)) { + if((size_t)snprintf(fname, sizeof(fname), "%s/%s", dname, ep->d_name) >= sizeof(fname)) { logger(LOG_ERR, "Pathname too long: %s/%s", dname, ep->d_name); return false; } @@ -578,7 +569,7 @@ FILE *ask_and_open(const char *filename, const char *what) { /* The directory is a relative path or a filename. */ getcwd(directory, sizeof(directory)); - if(snprintf(abspath, sizeof(abspath), "%s/%s", directory, fn) >= sizeof(abspath)) { + if((size_t)snprintf(abspath, sizeof(abspath), "%s/%s", directory, fn) >= sizeof(abspath)) { fprintf(stderr, "Pathname too long: %s/%s\n", directory, fn); return NULL; }