Make tunnel library actually work with X.509 certificate authentication.
[tinc] / tnl / tnl.c
index 5a767f5..75f82f7 100644 (file)
--- a/tnl/tnl.c
+++ b/tnl/tnl.c
 #include "system.h"
 
 #include <gnutls/gnutls.h>
+#include <gnutls/x509.h>
 
+#include "logger/logger.h"
 #include "support/avl.h"
 #include "support/sockaddr.h"
 #include "support/xalloc.h"
 #include "tnl/tnl.h"
 
-static avl_tree_t *tnls, *listeners;
-
-bool tnl_init(void) {
-       tnls = avl_tree_new(NULL, (avl_action_t)free);
-       listeners = avl_tree_new(NULL, (avl_action_t)free);
-
-       return true;
-}
-
-bool tnl_exit(void) {
-       avl_tree_del(listeners);
-       avl_tree_del(tnls);
-
-       return true;
-}
-
-#define tnl_add(t) avl_add(tnls, t)
-#define tnl_del(t) avl_del(tnls, t)
-#define tnl_listen_add(l) avl_add(listeners, l)
-#define tnl_listen_del(l) avl_del(listeners, l)
-
-static bool tnl_send(tnl_t *tnl, const char *buf, int len) {
+static bool tnl_send(tnl_t *tnl, const void *buf, int len) {
        int result;
 
        while(len) {
@@ -64,7 +45,8 @@ static bool tnl_send(tnl_t *tnl, const char *buf, int len) {
                        else
                                logger(LOG_INFO, _("tnl: connection closed by peer"));
 
-                       tnl->error(tnl, result);
+                       if(tnl->error)
+                               tnl->error(tnl, result);
                        tnl->close(tnl);
                        return !result;
                }
@@ -77,10 +59,10 @@ static bool tnl_send(tnl_t *tnl, const char *buf, int len) {
 }
 
 static bool tnl_recv(tnl_t *tnl) {
-       int result;
        tnl_record_t *record = (tnl_record_t *)tnl->buf;
 
-       result = gnutls_record_recv(tnl->session, tnl->buf + tnl->bufread, sizeof tnl->buf - tnl->bufread);
+#if 0
+       int result = gnutls_record_recv(tnl->session, tnl->buf + tnl->bufread, sizeof tnl->buf - tnl->bufread);
        if(result <= 0) {
                if(result == GNUTLS_E_INTERRUPTED || result == GNUTLS_E_AGAIN)
                        return true;
@@ -90,26 +72,31 @@ static bool tnl_recv(tnl_t *tnl) {
                else
                        logger(LOG_INFO, _("tnl: connection closed by peer"));
 
-               tnl->error(tnl, result);
+               if(tnl->error)
+                       tnl->error(tnl, result);
                tnl->close(tnl);
                return !result;
        }
 
        tnl->bufread += result;
+#endif
 
        while(tnl->bufread >= sizeof *record && tnl->bufread - sizeof *record >= record->len) {
                switch(record->type) {
                        case TNL_RECORD_META:
-                               tnl->recv_meta(tnl, record->data, record->len);
+                               if(tnl->recv_meta)
+                                       tnl->recv_meta(tnl, record->data, record->len);
                                break;
 
                        case TNL_RECORD_PACKET:
-                               tnl->recv_packet(tnl, record->data, record->len);
+                               if(tnl->recv_packet)
+                                       tnl->recv_packet(tnl, record->data, record->len);
                                break;
                                
                        default:
                                logger(LOG_ERR, _("tnl: error while receiving: %s"), _("unknown record type"));
-                               tnl->error(tnl, EINVAL);
+                               if(tnl->error)
+                                       tnl->error(tnl, EINVAL);
                                tnl->close(tnl);
                                return false;
                }
@@ -117,17 +104,31 @@ static bool tnl_recv(tnl_t *tnl) {
                tnl->bufread -= sizeof *record + record->len;
                memmove(tnl->buf, record->data + record->len, tnl->bufread);
        }
+
+       return true;
 }
 
 static bool tnl_recv_handler(fd_t *fd) {
+       if(!fd)
+               abort();
+
        tnl_t *tnl = fd->data;
        int result;
 
        result = gnutls_record_recv(tnl->session, tnl->buf + tnl->bufread, sizeof(tnl->buf) - tnl->bufread);
-       if(result < 0) {
+       if(result <= 0) {
+               if(!result) {
+                       logger(LOG_DEBUG, _("tnl: connection closed by peer %s (%s)"), tnl->remote.id, tnl->remote.hostname);
+                       if(tnl->error)
+                               tnl->error(tnl, 0);
+                       tnl->close(tnl);
+                       return false;
+               }       
+                                       
                if(gnutls_error_is_fatal(result)) {
-                       logger(LOG_DEBUG, _("tnl: reception failed: %s\n"), gnutls_strerror(result));
-                       tnl->error(tnl, result);
+                       logger(LOG_DEBUG, _("tnl: reception failed: %s"), gnutls_strerror(result));
+                       if(tnl->error)
+                               tnl->error(tnl, result);
                        tnl->close(tnl);
                        return false;
                }
@@ -139,14 +140,171 @@ static bool tnl_recv_handler(fd_t *fd) {
        return tnl_recv(tnl);
 }
 
+bool tnl_ep_set_x509_credentials(tnl_ep_t *tnl_ep, const char *privkey, const char *certificate, const char *trust, const char *crl) {
+       int err;
+
+       if(tnl_ep->cred.certificate) {
+               gnutls_certificate_free_credentials(tnl_ep->cred.certificate);
+               tnl_ep->cred.certificate = NULL;
+       }
+       
+       if((err = gnutls_certificate_allocate_credentials(&tnl_ep->cred.certificate)) < 0) {
+               logger(LOG_ERR, _("Failed to allocate certificate credentials: %s"), gnutls_strerror(err));
+               return false;
+       }
+
+       if((err = gnutls_certificate_set_x509_key_file(tnl_ep->cred.certificate, certificate, privkey, GNUTLS_X509_FMT_PEM)) < 0) {
+               logger(LOG_ERR, _("Failed to load X.509 key and/or certificate: %s"), gnutls_strerror(err));
+               return false;
+       }
+
+       tnl_ep->cred.type = GNUTLS_CRD_CERTIFICATE;
+
+       if(trust && (err = gnutls_certificate_set_x509_trust_file(tnl_ep->cred.certificate, trust, GNUTLS_X509_FMT_PEM)) < 0) {
+               logger(LOG_ERR, _("Failed to set X.509 trust file: %s"), gnutls_strerror(err));
+               return false;
+       }
+       
+       if(crl && (err = gnutls_certificate_set_x509_crl_file(tnl_ep->cred.certificate, crl, GNUTLS_X509_FMT_PEM)) < 0) {
+               logger(LOG_ERR, _("Failed to set X.509 CRL file: %s"), gnutls_strerror(err));
+               return false;
+       }
+
+       //gnutls_certificate_set_verify_flags(tnl_ep->cred.certificate, GNUTLS_VERIFY_DISABLE_CA_SIGN);
+
+       return true;
+}      
+
+bool tnl_ep_set_openpgp_credentials(tnl_ep_t *tnl_ep, const char *privkey, const char *pubkey, const char *keyring, const char *trustdb) {
+       int err;
+
+       if(tnl_ep->cred.certificate) {
+               gnutls_certificate_free_credentials(tnl_ep->cred.certificate);
+               tnl_ep->cred.certificate = NULL;
+       }
+       
+       if((err = gnutls_certificate_allocate_credentials(&tnl_ep->cred.certificate)) < 0) {
+               logger(LOG_ERR, _("Failed to allocate certificate credentials: %s"), gnutls_strerror(err));
+               return false;
+       }
+
+       if((err = gnutls_certificate_set_openpgp_key_file(tnl_ep->cred.certificate, pubkey, privkey)) < 0) {
+               logger(LOG_ERR, _("Failed to load public and/or private OpenPGP key: %s"), gnutls_strerror(err));
+               return false;
+       }
+
+       tnl_ep->cred.type = GNUTLS_CRD_CERTIFICATE;
+
+       if(keyring && (err = gnutls_certificate_set_openpgp_keyring_file(tnl_ep->cred.certificate, keyring)) < 0) {
+               logger(LOG_ERR, _("Failed to set OpenPGP keyring file: %s"), gnutls_strerror(err));
+               return false;
+       }
+       
+       if(trustdb && (err = gnutls_certificate_set_openpgp_trustdb(tnl_ep->cred.certificate, trustdb)) < 0) {
+               logger(LOG_ERR, _("Failed to set OpenPGP trustdb file: %s"), gnutls_strerror(err));
+               return false;
+       }
+
+       //gnutls_certificate_set_verify_flags(tnl_ep->cred.certificate, GNUTLS_VERIFY_DISABLE_CA_SIGN);
+
+       return true;
+}              
+
+static bool tnl_authenticate_x509(tnl_t *tnl) {
+       gnutls_x509_crt cert;
+        const gnutls_datum *certs;
+        int ncerts = 0, result;
+       char name[1024];
+       int len;
+
+       certs = gnutls_certificate_get_peers(tnl->session, &ncerts);
+
+       if (!certs || !ncerts) {
+               logger(LOG_ERR, _("tnl: no certificates from %s"), tnl->remote.hostname);
+               return false;
+       }
+
+       gnutls_x509_crt_init(&cert);
+       result = gnutls_x509_crt_import(cert, certs, GNUTLS_X509_FMT_DER);
+
+       if(result) {
+               logger(LOG_ERR, _("tnl: error importing certificate from %s: %s"), tnl->remote.hostname, gnutls_strerror(result));
+               gnutls_x509_crt_deinit(cert);
+               return false;
+       }
+
+       len = sizeof name;
+       result = gnutls_x509_crt_get_dn_by_oid(cert, GNUTLS_OID_X520_COMMON_NAME, 0, 0, name, &len);
+       gnutls_x509_crt_deinit(cert);
+       
+       if(result) {
+               logger(LOG_ERR, _("tnl: could not extract common name from certificate from %s: %s"), tnl->remote.hostname, gnutls_strerror(result));
+               return false;
+       }
+
+       if(len > sizeof name) {
+               logger(LOG_ERR, _("tnl: common name from certificate from %s too long"), tnl->remote.hostname);
+               return false;
+       }
+
+       if(tnl->remote.id && strcmp(tnl->remote.id, name)) {
+               logger(LOG_ERR, _("tnl: peer %s is %s instead of %s"), tnl->remote.hostname, name, tnl->remote.id);
+               return false;
+       }
+
+       replace(tnl->remote.id, xstrdup(name));
+
+       result = gnutls_certificate_verify_peers(tnl->session);
+
+       if(result < 0) {
+               logger(LOG_ERR, "tnl: error verifying certificate from %s (%s): %s", tnl->remote.id, tnl->remote.hostname, gnutls_strerror(result));
+               return false;
+       }
+
+       if(result) {
+               logger(LOG_ERR, "tnl: certificate from %s (%s) not good, verification result %x", tnl->remote.id, tnl->remote.hostname, result);
+               return false;
+       }
+
+       return true;
+}
+
+static bool tnl_authenticate(tnl_t *tnl) {
+       switch(tnl->local.cred.type) {
+               case GNUTLS_CRD_CERTIFICATE:
+                       switch(gnutls_certificate_type_get(tnl->session)) {
+                               case GNUTLS_CRT_X509:
+                                       return tnl_authenticate_x509(tnl);
+                               case GNUTLS_CRT_OPENPGP:
+                                       //return tnl_authenticate_openpgp(tnl);
+                               default:
+                                       logger(LOG_ERR, "tnl: unknown certificate type for session with %s (%s)", tnl->remote.id, tnl->remote.hostname);
+                                       return false;
+                       }
+
+               case GNUTLS_CRD_ANON:
+                       logger(LOG_ERR, "tnl: anonymous authentication not yet supported");
+                       return false;
+
+               case GNUTLS_CRD_SRP:
+                       logger(LOG_ERR, "tnl: SRP authentication not yet supported");
+                       return false;
+                               
+               default:
+                       logger(LOG_ERR, "tnl: unknown authentication type for session with %s (%s)", tnl->remote.id, tnl->remote.hostname);
+                       return false;
+       }
+}
+
 static bool tnl_handshake_handler(fd_t *fd) {
+       //char id[1024];
        tnl_t *tnl = fd->data;
        int result;
 
        result = gnutls_handshake(tnl->session);
        if(result < 0) {
                if(gnutls_error_is_fatal(result)) {
-                       logger(LOG_ERR, "tnl: handshake error: %s\n", gnutls_strerror(result));
+                       logger(LOG_ERR, "tnl: handshake error: %s", gnutls_strerror(result));
                        tnl->close(tnl);
                        return false;
                }
@@ -157,41 +315,33 @@ static bool tnl_handshake_handler(fd_t *fd) {
        
        logger(LOG_DEBUG, _("tnl: handshake finished"));
 
-       result = gnutls_certificate_verify_peers(tnl->session);
-       if(result < 0) {
-               logger(LOG_ERR, "tnl: certificate error: %s\n", gnutls_strerror(result));
-               tnl->close(tnl);
+       if(!tnl_authenticate(tnl))
                return false;
-       }
 
-       if(result) {
-               logger(LOG_ERR, "tnl: certificate not good, verification result %x", result);
-               tnl->close(tnl);
-               return false;
-       }
+       tnl->status = TNL_STATUS_UP;
+       tnl->fd.read = tnl_recv_handler;
+       if(tnl->accept)
+               tnl->accept(tnl);
 
-       tnl->status == TNL_STATUS_UP;
-       tnl->fd.handler = tnl_recv_handler;
-       tnl->accept(tnl);
        return true;
 }
 
-static bool tnl_send_meta(tnl_t *tnl, const char *buf, int len) {
+static bool tnl_send_meta(tnl_t *tnl, const void *buf, int len) {
        tnl_record_t record = {
                .type = TNL_RECORD_META,
                .len = len,
        };
 
-       return tnl_send(tnl, (char *)&record, sizeof(record)) && tnl_send(tnl, buf, len);
+       return tnl_send(tnl, &record, sizeof record) && tnl_send(tnl, buf, len);
 }
 
-static bool tnl_send_packet(tnl_t *tnl, const char *buf, int len) {
+static bool tnl_send_packet(tnl_t *tnl, const void *buf, int len) {
        tnl_record_t record = {
                .type = TNL_RECORD_PACKET,
                .len = len,
        };
 
-       return tnl_send(tnl, (char *)&record, sizeof(record)) && tnl_send(tnl, buf, len);
+       return tnl_send(tnl, &record, sizeof record) && tnl_send(tnl, buf, len);
 }
 
 static bool tnl_close(tnl_t *tnl) {
@@ -203,13 +353,6 @@ static bool tnl_close(tnl_t *tnl) {
        fd_del(&tnl->fd);
        close(tnl->fd.fd);
        
-       tnl_del(tnl);
-
-       return true;
-}
-
-static bool tnl_accept_error(tnl_t *tnl, int errnum) {
-       logger(LOG_ERR, _("tnl: error %d on accepted tunnel"));
        return true;
 }
 
@@ -227,11 +370,11 @@ static bool tnl_accept_handler(fd_t *fd) {
                return false;
        }
 
-       logger(LOG_DEBUG, _("tnl: accepted incoming connection"));
-
        sa_unmap(&ss);
+       
+       logger(LOG_DEBUG, _("tnl: accepted incoming connection"));
 
-       new(tnl);
+       clear(new(tnl));
        tnl->local = listener->local;
        tnl->remote.address = ss;
        len = sizeof tnl->local.address;
@@ -239,30 +382,29 @@ static bool tnl_accept_handler(fd_t *fd) {
        sa_unmap(&tnl->local.address);
        tnl->type = listener->type;
        tnl->protocol = listener->protocol;
-       tnl->status = TNL_STATUS_CONNECTING;
-       tnl->error = tnl_accept_error;
+       tnl->send_packet = tnl_send_packet;
+       tnl->send_meta = tnl_send_meta;
        tnl->close = tnl_close;
 
        tnl->fd.fd = sock;
-       tnl->fd.mode = FD_MODE_READ;
-       tnl->fd.handler = tnl_handshake_handler;
+       tnl->fd.read = tnl_handshake_handler;
        tnl->fd.data = tnl;
 
        fcntl(sock, F_SETFL, fcntl(sock, F_GETFL) | O_NONBLOCK);
 
-       tnl_add(tnl);
-
+       tnl->status = TNL_STATUS_HANDSHAKE;
        gnutls_init(&tnl->session, GNUTLS_SERVER);
        //gnutls_handshake_set_private_extensions(tnl->session, 1);
        gnutls_set_default_priority(tnl->session);
-       gnutls_credentials_set(tnl->session, GNUTLS_CRD_CERTIFICATE, tnl->local.cred);
+       gnutls_credentials_set(tnl->session, tnl->local.cred.type, tnl->local.cred.certificate);
        gnutls_certificate_server_set_request(tnl->session, GNUTLS_CERT_REQUEST);
        gnutls_transport_set_ptr(tnl->session, (gnutls_transport_ptr)sock);
-       gnutls_handshake(tnl->session);
 
        tnl->accept = listener->accept;
        
        fd_add(&tnl->fd);
+
+       tnl_handshake_handler(&tnl->fd);
        
        return true;
 }      
@@ -276,30 +418,30 @@ static bool tnl_connect_handler(fd_t *fd) {
        getsockopt(fd->fd, SOL_SOCKET, SO_ERROR, &result, &len);
        if(result) {
                logger(LOG_ERR, "tnl: error while connecting: %s", strerror(result));
-               tnl->error(tnl, result);
+               if(tnl->error)
+                       tnl->error(tnl, result);
                tnl->close(tnl);
                return false;
        }
        
-       fd_del(&tnl->fd);
-
+       logger(LOG_DEBUG, _("tnl: connected"));
+       
        fcntl(tnl->fd.fd, F_SETFL, fcntl(tnl->fd.fd, F_GETFL) | O_NONBLOCK);
 
        tnl->status = TNL_STATUS_HANDSHAKE;
        gnutls_init(&tnl->session, GNUTLS_CLIENT);
        //gnutls_handshake_set_private_extensions(tnl->session, 1);
        gnutls_set_default_priority(tnl->session);
-       gnutls_credentials_set(tnl->session, GNUTLS_CRD_CERTIFICATE, tnl->local.cred);
+       gnutls_credentials_set(tnl->session, tnl->local.cred.type, tnl->local.cred.certificate);
        gnutls_certificate_server_set_request(tnl->session, GNUTLS_CERT_REQUEST);
        gnutls_transport_set_ptr(tnl->session, (gnutls_transport_ptr)fd->fd);
-       gnutls_handshake(tnl->session);
 
-       tnl->fd.mode = FD_MODE_READ;
-       tnl->fd.handler = tnl_handshake_handler;
-       fd_add(&tnl->fd);
+       tnl->fd.write = NULL;
+       tnl->fd.read = tnl_handshake_handler;
+       fd_mod(&tnl->fd);
+
+       tnl_handshake_handler(&tnl->fd);
 
-       logger(LOG_DEBUG, _("tnl: connected"));
-       
        return true;
 }
 
@@ -330,17 +472,13 @@ bool tnl_connect(tnl_t *tnl) {
        tnl->status = TNL_STATUS_CONNECTING;
 
        tnl->fd.fd = sock;
-       tnl->fd.mode = FD_MODE_WRITE;
-       tnl->fd.handler = tnl_connect_handler;
+       tnl->fd.write = tnl_connect_handler;
        tnl->fd.data = tnl;
 
        tnl->send_packet = tnl_send_packet;
        tnl->send_meta = tnl_send_meta;
        tnl->close = tnl_close;
        
-       tnl_add(tnl);
-
-
        fd_add(&tnl->fd);
 
        return true;
@@ -349,7 +487,6 @@ bool tnl_connect(tnl_t *tnl) {
 static bool tnl_listen_close(tnl_listen_t *listener) {
        fd_del(&listener->fd);
        close(listener->fd.fd);
-       tnl_listen_del(listener);
        return true;
 }
 
@@ -374,12 +511,10 @@ bool tnl_listen(tnl_listen_t *listener) {
        }
 
        listener->fd.fd = sock;
-       listener->fd.mode = FD_MODE_READ;
-       listener->fd.handler = tnl_accept_handler;
+       listener->fd.read = tnl_accept_handler;
        listener->fd.data = listener;
        listener->close = tnl_listen_close;
 
-       tnl_listen_add(listener);
        fd_add(&listener->fd);
 
        return true;