Add basic pledge/unveil sandbox on OpenBSD
[tinc] / src / tincd.c
index dee38ef..539f527 100644 (file)
@@ -1,7 +1,7 @@
 /*
     tincd.c -- the main file for tincd
     Copyright (C) 1998-2005 Ivo Timmermans
-                  2000-2021 Guus Sliepen <guus@tinc-vpn.org>
+                  2000-2022 Guus Sliepen <guus@tinc-vpn.org>
                   2008      Max Rijevski <maksuf@gmail.com>
                   2009      Michael Tokarev <mjt@tls.msk.ru>
                   2010      Julien Muchembled <jm@jmuchemb.eu>
 #define _P1003_1B_VISIBLE
 #endif
 
-#ifdef HAVE_SYS_MMAN_H
-#include <sys/mman.h>
-#endif
-
 #ifdef HAVE_LZO
 #include LZO1X_H
 #endif
 
-#ifdef LZ4_H
-#include LZ4_H
+#ifdef HAVE_LZ4
+#include <lz4.h>
 #endif
 
-#ifndef HAVE_MINGW
+#ifndef HAVE_WINDOWS
 #include <pwd.h>
 #include <grp.h>
 #include <time.h>
@@ -58,6 +54,8 @@
 #include "utils.h"
 #include "xalloc.h"
 #include "version.h"
+#include "random.h"
+#include "sandbox.h"
 
 /* If nonzero, display usage information and exit. */
 static bool show_help = false;
@@ -65,15 +63,12 @@ static bool show_help = false;
 /* If nonzero, print the version on standard output and exit.  */
 static bool show_version = false;
 
-/* If nonzero, use null ciphers and skip all key exchanges. */
-bool bypass_security = false;
-
 #ifdef HAVE_MLOCKALL
 /* If nonzero, disable swapping for this process. */
 static bool do_mlock = false;
 #endif
 
-#ifndef HAVE_MINGW
+#ifndef HAVE_WINDOWS
 /* If nonzero, chroot to netdir after startup. */
 static bool do_chroot = false;
 
@@ -81,35 +76,52 @@ static bool do_chroot = false;
 static const char *switchuser = NULL;
 #endif
 
-/* If nonzero, write log entries to a separate file. */
-bool use_logfile = false;
-
-/* If nonzero, use syslog instead of stderr in no-detach mode. */
-bool use_syslog = false;
-
 char **g_argv;                  /* a copy of the cmdline arguments */
 
 static int status = 1;
 
+typedef enum option_t {
+       OPT_BAD_OPTION  = '?',
+       OPT_LONG_OPTION =  0,
+
+       // Short options
+       OPT_CONFIG_FILE = 'c',
+       OPT_NETNAME     = 'n',
+       OPT_NO_DETACH   = 'D',
+       OPT_DEBUG       = 'd',
+       OPT_MLOCK       = 'L',
+       OPT_CHROOT      = 'R',
+       OPT_CHANGE_USER = 'U',
+       OPT_SYSLOG      = 's',
+       OPT_OPTION      = 'o',
+
+       // Long options
+       OPT_HELP        = 255,
+       OPT_VERSION,
+       OPT_NO_SECURITY,
+       OPT_LOGFILE,
+       OPT_PIDFILE,
+} option_t;
+
 static struct option const long_options[] = {
-       {"config", required_argument, NULL, 'c'},
-       {"net", required_argument, NULL, 'n'},
-       {"help", no_argument, NULL, 1},
-       {"version", no_argument, NULL, 2},
-       {"no-detach", no_argument, NULL, 'D'},
-       {"debug", optional_argument, NULL, 'd'},
-       {"bypass-security", no_argument, NULL, 3},
-       {"mlock", no_argument, NULL, 'L'},
-       {"chroot", no_argument, NULL, 'R'},
-       {"user", required_argument, NULL, 'U'},
-       {"logfile", optional_argument, NULL, 4},
-       {"syslog", no_argument, NULL, 's'},
-       {"pidfile", required_argument, NULL, 5},
-       {"option", required_argument, NULL, 'o'},
-       {NULL, 0, NULL, 0}
+       {"config",          required_argument, NULL, OPT_CONFIG_FILE},
+       {"net",             required_argument, NULL, OPT_NETNAME},
+       {"no-detach",       no_argument,       NULL, OPT_NO_DETACH},
+       {"debug",           optional_argument, NULL, OPT_DEBUG},
+       {"mlock",           no_argument,       NULL, OPT_MLOCK},
+       {"chroot",          no_argument,       NULL, OPT_CHROOT},
+       {"user",            required_argument, NULL, OPT_CHANGE_USER},
+       {"syslog",          no_argument,       NULL, OPT_SYSLOG},
+       {"option",          required_argument, NULL, OPT_OPTION},
+       {"help",            no_argument,       NULL, OPT_HELP},
+       {"version",         no_argument,       NULL, OPT_VERSION},
+       {"bypass-security", no_argument,       NULL, OPT_NO_SECURITY},
+       {"logfile",         optional_argument, NULL, OPT_LOGFILE},
+       {"pidfile",         required_argument, NULL, OPT_PIDFILE},
+       {NULL,              0,                 NULL, 0},
 };
 
-#ifdef HAVE_MINGW
+#ifdef HAVE_WINDOWS
 static struct WSAData wsa_state;
 int main2(int argc, char **argv);
 #endif
@@ -119,29 +131,44 @@ static void usage(bool status) {
                fprintf(stderr, "Try `%s --help\' for more information.\n",
                        program_name);
        else {
-               printf("Usage: %s [option]...\n\n", program_name);
-               printf("  -c, --config=DIR              Read configuration options from DIR.\n"
-                      "  -D, --no-detach               Don't fork and detach.\n"
-                      "  -d, --debug[=LEVEL]           Increase debug level or set it to LEVEL.\n"
-                      "  -n, --net=NETNAME             Connect to net NETNAME.\n"
+               fprintf(stdout,
+                       "Usage: %s [option]...\n"
+                       "\n"
+                       "  -c, --config=DIR              Read configuration options from DIR.\n"
+                       "  -D, --no-detach               Don't fork and detach.\n"
+                       "  -d, --debug[=LEVEL]           Increase debug level or set it to LEVEL.\n"
+                       "  -n, --net=NETNAME             Connect to net NETNAME.\n"
 #ifdef HAVE_MLOCKALL
-                      "  -L, --mlock                   Lock tinc into main memory.\n"
-#endif
-                      "      --logfile[=FILENAME]      Write log entries to a logfile.\n"
-                      "  -s  --syslog                  Use syslog instead of stderr with --no-detach.\n"
-                      "      --pidfile=FILENAME        Write PID and control socket cookie to FILENAME.\n"
-                      "      --bypass-security         Disables meta protocol security, for debugging.\n"
-                      "  -o, --option[HOST.]KEY=VALUE  Set global/host configuration value.\n"
-#ifndef HAVE_MINGW
-                      "  -R, --chroot                  chroot to NET dir at startup.\n"
-                      "  -U, --user=USER               setuid to given USER at startup.\n"
-#endif
-                      "      --help                    Display this help and exit.\n"
-                      "      --version                 Output version information and exit.\n\n");
-               printf("Report bugs to tinc@tinc-vpn.org.\n");
+                       "  -L, --mlock                   Lock tinc into main memory.\n"
+#endif
+                       "      --logfile[=FILENAME]      Write log entries to a logfile.\n"
+                       "  -s  --syslog                  Use syslog instead of stderr with --no-detach.\n"
+                       "      --pidfile=FILENAME        Write PID and control socket cookie to FILENAME.\n"
+                       "      --bypass-security         Disables meta protocol security, for debugging.\n"
+                       "  -o, --option[HOST.]KEY=VALUE  Set global/host configuration value.\n"
+#ifndef HAVE_WINDOWS
+                       "  -R, --chroot                  chroot to NET dir at startup.\n"
+                       "  -U, --user=USER               setuid to given USER at startup.\n"
+#endif
+                       "      --help                    Display this help and exit.\n"
+                       "      --version                 Output version information and exit.\n"
+                       "\n"
+                       "Report bugs to tinc@tinc-vpn.org.\n",
+                       program_name);
        }
 }
 
+// Try to resolve path to absolute, return a copy of the argument if this fails.
+static char *get_path_arg(char *arg) {
+       char *result = absolute_path(arg);
+
+       if(!result) {
+               result = xstrdup(arg);
+       }
+
+       return result;
+}
+
 static bool parse_options(int argc, char **argv) {
        config_t *cfg;
        int r;
@@ -149,20 +176,24 @@ static bool parse_options(int argc, char **argv) {
        int lineno = 0;
 
        while((r = getopt_long(argc, argv, "c:DLd::n:so:RU:", long_options, &option_index)) != EOF) {
-               switch(r) {
-               case 0:   /* long option */
+               switch((option_t) r) {
+               case OPT_LONG_OPTION:
                        break;
 
-               case 'c': /* config file */
+               case OPT_BAD_OPTION:
+                       usage(true);
+                       goto exit_fail;
+
+               case OPT_CONFIG_FILE:
                        free(confbase);
-                       confbase = xstrdup(optarg);
+                       confbase = get_path_arg(optarg);
                        break;
 
-               case 'D': /* no detach */
+               case OPT_NO_DETACH:
                        do_detach = false;
                        break;
 
-               case 'L': /* no detach */
+               case OPT_MLOCK: /* lock tincd into RAM */
 #ifndef HAVE_MLOCKALL
                        logger(DEBUG_ALWAYS, LOG_ERR, "The %s option is not supported on this platform.", argv[optind - 1]);
                        goto exit_fail;
@@ -171,7 +202,7 @@ static bool parse_options(int argc, char **argv) {
                        break;
 #endif
 
-               case 'd': /* increase debug level */
+               case OPT_DEBUG: /* increase debug level */
                        if(!optarg && optind < argc && *argv[optind] != '-') {
                                optarg = argv[optind++];
                        }
@@ -184,17 +215,17 @@ static bool parse_options(int argc, char **argv) {
 
                        break;
 
-               case 'n': /* net name given */
+               case OPT_NETNAME:
                        free(netname);
                        netname = xstrdup(optarg);
                        break;
 
-               case 's': /* syslog */
+               case OPT_SYSLOG:
                        use_logfile = false;
                        use_syslog = true;
                        break;
 
-               case 'o': /* option */
+               case OPT_OPTION:
                        cfg = parse_config_line(optarg, NULL, ++lineno);
 
                        if(!cfg) {
@@ -204,36 +235,36 @@ static bool parse_options(int argc, char **argv) {
                        list_insert_tail(&cmdline_conf, cfg);
                        break;
 
-#ifdef HAVE_MINGW
+#ifdef HAVE_WINDOWS
 
-               case 'R':
-               case 'U':
+               case OPT_CHANGE_USER:
+               case OPT_CHROOT:
                        logger(DEBUG_ALWAYS, LOG_ERR, "The %s option is not supported on this platform.", argv[optind - 1]);
                        goto exit_fail;
 #else
 
-               case 'R': /* chroot to NETNAME dir */
+               case OPT_CHROOT:
                        do_chroot = true;
                        break;
 
-               case 'U': /* setuid to USER */
+               case OPT_CHANGE_USER:
                        switchuser = optarg;
                        break;
 #endif
 
-               case 1:   /* show help */
+               case OPT_HELP:
                        show_help = true;
                        break;
 
-               case 2:   /* show version */
+               case OPT_VERSION:
                        show_version = true;
                        break;
 
-               case 3:   /* bypass security */
+               case OPT_NO_SECURITY:
                        bypass_security = true;
                        break;
 
-               case 4:   /* write log entries to a file */
+               case OPT_LOGFILE:
                        use_syslog = false;
                        use_logfile = true;
 
@@ -243,20 +274,16 @@ static bool parse_options(int argc, char **argv) {
 
                        if(optarg) {
                                free(logfilename);
-                               logfilename = xstrdup(optarg);
+                               logfilename = get_path_arg(optarg);
                        }
 
                        break;
 
-               case 5:   /* open control socket here */
+               case OPT_PIDFILE:
                        free(pidfilename);
-                       pidfilename = xstrdup(optarg);
+                       pidfilename = get_path_arg(optarg);
                        break;
 
-               case '?': /* wrong options */
-                       usage(true);
-                       goto exit_fail;
-
                default:
                        break;
                }
@@ -296,8 +323,46 @@ exit_fail:
        return false;
 }
 
+static bool read_sandbox_level(void) {
+       sandbox_level_t level;
+       char *value = NULL;
+
+       if(get_config_string(lookup_config(&config_tree, "Sandbox"), &value)) {
+               if(!strcasecmp("off", value)) {
+                       level = SANDBOX_NONE;
+               } else if(!strcasecmp("normal", value)) {
+                       level = SANDBOX_NORMAL;
+               } else if(!strcasecmp("high", value)) {
+                       level = SANDBOX_HIGH;
+               } else {
+                       logger(DEBUG_ALWAYS, LOG_ERR, "Bad sandbox value %s!", value);
+                       free(value);
+                       return false;
+               }
+
+               free(value);
+       } else {
+#ifdef HAVE_SANDBOX
+               level = SANDBOX_NORMAL;
+#else
+               level = SANDBOX_NONE;
+#endif
+       }
+
+#ifndef HAVE_SANDBOX
+
+       if(level > SANDBOX_NONE) {
+               logger(DEBUG_ALWAYS, LOG_ERR, "Sandbox is used but is not supported on this platform");
+               return false;
+       }
+
+#endif
+       sandbox_set_level(level);
+       return true;
+}
+
 static bool drop_privs(void) {
-#ifndef HAVE_MINGW
+#ifndef HAVE_WINDOWS
        uid_t uid = 0;
 
        if(switchuser) {
@@ -347,10 +412,11 @@ static bool drop_privs(void) {
                }
 
 #endif
-       return true;
+
+       return sandbox_enter();
 }
 
-#ifdef HAVE_MINGW
+#ifdef HAVE_WINDOWS
 # define setpriority(level) !SetPriorityClass(GetCurrentProcess(), (level))
 
 static void stop_handler(void *data, int flags) {
@@ -378,11 +444,8 @@ static BOOL WINAPI console_ctrl_handler(DWORD type) {
 # define setpriority(level) (setpriority(PRIO_PROCESS, 0, (level)))
 #endif
 
-static void cleanup() {
-       if(config_tree) {
-               exit_configuration(&config_tree);
-       }
-
+static void cleanup(void) {
+       splay_empty_tree(&config_tree);
        list_empty_list(&cmdline_conf);
        free_names();
 }
@@ -395,49 +458,53 @@ int main(int argc, char **argv) {
        }
 
        if(show_version) {
-               printf("%s version %s (built %s %s, protocol %d.%d)\n", PACKAGE,
-                      BUILD_VERSION, BUILD_DATE, BUILD_TIME, PROT_MAJOR, PROT_MINOR);
-               printf("Features:"
+               fprintf(stdout,
+                       "%s version %s (built %s %s, protocol %d.%d)\n"
+                       "Features:"
 #ifdef HAVE_OPENSSL
-                      " openssl"
+                       " openssl"
 #endif
 #ifdef HAVE_LIBGCRYPT
-                      " libgcrypt"
+                       " libgcrypt"
 #endif
 #ifdef HAVE_LZO
-                      " comp_lzo"
+                       " comp_lzo"
 #endif
 #ifdef HAVE_ZLIB
-                      " comp_zlib"
+                       " comp_zlib"
 #endif
 #ifdef HAVE_LZ4
-                      " comp_lz4"
+                       " comp_lz4"
 #endif
 #ifndef DISABLE_LEGACY
-                      " legacy_protocol"
+                       " legacy_protocol"
 #endif
 #ifdef ENABLE_JUMBOGRAMS
-                      " jumbograms"
+                       " jumbograms"
 #endif
 #ifdef ENABLE_TUNEMU
-                      " tunemu"
+                       " tunemu"
 #endif
 #ifdef HAVE_MINIUPNPC
-                      " miniupnpc"
+                       " miniupnpc"
+#endif
+#ifdef HAVE_SANDBOX
+                       " sandbox"
 #endif
 #ifdef ENABLE_UML
-                      " uml"
+                       " uml"
 #endif
 #ifdef ENABLE_VDE
-                      " vde"
-#endif
-                      "\n\n");
-               printf("Copyright (C) 1998-2021 Ivo Timmermans, Guus Sliepen and others.\n"
-                      "See the AUTHORS file for a complete list.\n\n"
-                      "tinc comes with ABSOLUTELY NO WARRANTY.  This is free software,\n"
-                      "and you are welcome to redistribute it under certain conditions;\n"
-                      "see the file COPYING for details.\n");
-
+                       " vde"
+#endif
+                       "\n\n"
+                       "Copyright (C) 1998-2021 Ivo Timmermans, Guus Sliepen and others.\n"
+                       "See the AUTHORS file for a complete list.\n"
+                       "\n"
+                       "tinc comes with ABSOLUTELY NO WARRANTY.  This is free software,\n"
+                       "and you are welcome to redistribute it under certain conditions;\n"
+                       "see the file COPYING for details.\n",
+                       PACKAGE, BUILD_VERSION, BUILD_DATE, BUILD_TIME, PROT_MAJOR, PROT_MINOR);
                return 0;
        }
 
@@ -449,9 +516,12 @@ int main(int argc, char **argv) {
        make_names(true);
        atexit(cleanup);
 
-       chdir(confbase);
+       if(chdir(confbase) == -1) {
+               logger(DEBUG_ALWAYS, LOG_ERR, "Could not change to configuration directory: %s", strerror(errno));
+               return 1;
+       }
 
-#ifdef HAVE_MINGW
+#ifdef HAVE_WINDOWS
 
        if(WSAStartup(MAKEWORD(2, 2), &wsa_state)) {
                logger(DEBUG_ALWAYS, LOG_ERR, "System call `%s' failed: %s", "WSAStartup", winerror(GetLastError()));
@@ -463,7 +533,9 @@ int main(int argc, char **argv) {
        char *umbstr = getenv("TINC_UMBILICAL");
 
        if(umbstr) {
-               umbilical = atoi(umbstr);
+               int colorize = 0;
+               sscanf(umbstr, "%d %d", &umbilical, &colorize);
+               umbilical_colorize = colorize;
 
                if(fcntl(umbilical, F_GETFL) < 0) {
                        umbilical = 0;
@@ -492,22 +564,23 @@ int main(int argc, char **argv) {
        unsetenv("LISTEN_PID");
 #endif
 
-       init_configuration(&config_tree);
-
-       /* Slllluuuuuuurrrrp! */
-
        gettimeofday(&now, NULL);
-       srand(now.tv_sec + now.tv_usec);
+       random_init();
        crypto_init();
+       prng_init();
+
+       if(!read_server_config(&config_tree)) {
+               return 1;
+       }
 
-       if(!read_server_config(config_tree)) {
+       if(!read_sandbox_level()) {
                return 1;
        }
 
        if(debug_level == DEBUG_NOTHING) {
                int level = 0;
 
-               if(get_config_int(lookup_config(config_tree, "LogLevel"), &level)) {
+               if(get_config_int(lookup_config(&config_tree, "LogLevel"), &level)) {
                        debug_level = level;
                }
        }
@@ -521,7 +594,7 @@ int main(int argc, char **argv) {
 
 #endif
 
-#ifdef HAVE_MINGW
+#ifdef HAVE_WINDOWS
        io_add_event(&stop_io, stop_handler, NULL, WSACreateEvent());
 
        if(stop_io.event == FALSE) {
@@ -576,7 +649,7 @@ int main2(int argc, char **argv) {
 
        /* Change process priority */
 
-       if(get_config_string(lookup_config(config_tree, "ProcessPriority"), &priority)) {
+       if(get_config_string(lookup_config(&config_tree, "ProcessPriority"), &priority)) {
                if(!strcasecmp(priority, "Normal")) {
                        if(setpriority(NORMAL_PRIORITY_CLASS) != 0) {
                                logger(DEBUG_ALWAYS, LOG_ERR, "System call `%s' failed: %s", "setpriority", strerror(errno));
@@ -608,7 +681,10 @@ int main2(int argc, char **argv) {
        logger(DEBUG_ALWAYS, LOG_NOTICE, "Ready");
 
        if(umbilical) { // snip!
-               write(umbilical, "", 1);
+               if(write(umbilical, "", 1) != 1) {
+                       // Pipe full or broken, nothing we can do about it.
+               }
+
                close(umbilical);
                umbilical = 0;
        }
@@ -626,7 +702,7 @@ end:
 
        free(priority);
 
-       crypto_exit();
+       random_exit();
 
        return status;
 }