s/sliepen.warande.net/sliepen.eu.org/g

[tinc] / src / protocol_edge.c

diff --git a/src/protocol_edge.c b/src/protocol_edge.c
index 0c5ca35..a13a096 100644 (file)
--- a/src/protocol_edge.c
+++ b/src/protocol_edge.c
@@ -1,7 +1,7 @@
 /*
     protocol_edge.c -- handle the meta-protocol, edges
-    Copyright (C) 1999-2002 Ivo Timmermans <itimmermans@bigfoot.com>,
-                  2000-2002 Guus Sliepen <guus@sliepen.warande.net>
+    Copyright (C) 1999-2002 Ivo Timmermans <ivo@o2w.nl>,
+                  2000-2002 Guus Sliepen <guus@sliepen.eu.org>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
@@ -17,7 +17,7 @@
     along with this program; if not, write to the Free Software
     Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 
-    $Id: protocol_edge.c,v 1.1.4.2 2002/02/18 16:25:18 guus Exp $
+    $Id: protocol_edge.c,v 1.1.4.8 2002/06/21 10:11:19 guus Exp $
 */
 
 #include "config.h"
@@ -48,23 +48,17 @@
 int send_add_edge(connection_t *c, edge_t *e)
 {
   int x;
-  char *from_tcpaddress, *from_tcpport, *from_udpaddress, *from_udpport;
-  char *to_tcpaddress, *to_tcpport, *to_udpaddress, *to_udpport;
+  char *from_udpaddress, *from_udpport;
+  char *to_udpaddress, *to_udpport;
 cp
-  sockaddr2str(&e->from.tcpaddress, &from_tcpaddress, &from_tcpport);
   sockaddr2str(&e->from.udpaddress, &from_udpaddress, &from_udpport);
-  sockaddr2str(&e->to.tcpaddress, &to_tcpaddress, &to_tcpport);
   sockaddr2str(&e->to.udpaddress, &to_udpaddress, &to_udpport);
-  x = send_request(c, "%d %s %s %s %s %s %s %s %s %lx %d", ADD_EDGE,
-                      e->from.node->name, from_tcpaddress, from_tcpport, from_udpport,
-                     e->to.node->name, to_tcpaddress, to_tcpport, to_udpport,
+  x = send_request(c, "%d %lx %s %s %s %s %s %s %lx %d", ADD_EDGE, random(),
+                      e->from.node->name, from_udpaddress, from_udpport,
+                     e->to.node->name, to_udpaddress, to_udpport,
                      e->options, e->weight);
-  free(from_tcpaddress);
-  free(from_tcpport);
   free(from_udpaddress);
   free(from_udpport);
-  free(to_tcpaddress);
-  free(to_tcpport);
   free(to_udpaddress);
   free(to_udpport);
 cp
@@ -79,21 +73,19 @@ int add_edge_h(connection_t *c)
   char from_name[MAX_STRING_SIZE];
   char to_name[MAX_STRING_SIZE];
   char from_address[MAX_STRING_SIZE];
-  char from_tcpport[MAX_STRING_SIZE];
   char from_udpport[MAX_STRING_SIZE];
   char to_address[MAX_STRING_SIZE];
-  char to_tcpport[MAX_STRING_SIZE];
   char to_udpport[MAX_STRING_SIZE];
-  sockaddr_t from_tcpaddress, from_udpaddress;
-  sockaddr_t to_tcpaddress, to_udpaddress;
+  sockaddr_t from_udpaddress;
+  sockaddr_t to_udpaddress;
   long int options;
   int weight;
   avl_node_t *node;
 cp
-  if(sscanf(c->buffer, "%*d "MAX_STRING" "MAX_STRING" "MAX_STRING" "MAX_STRING" "MAX_STRING" "MAX_STRING" "MAX_STRING" "MAX_STRING" %lx %d",
-            from_name, from_address, from_tcpport, from_udpport,
-           to_name, to_address, to_tcpport, to_udpport,
-           &options, &weight) != 10)
+  if(sscanf(c->buffer, "%*d %*x "MAX_STRING" "MAX_STRING" "MAX_STRING" "MAX_STRING" "MAX_STRING" "MAX_STRING" %lx %d",
+            from_name, from_address, from_udpport,
+           to_name, to_address, to_udpport,
+           &options, &weight) != 8)
     {
        syslog(LOG_ERR, _("Got bad %s from %s (%s)"), "ADD_EDGE", c->name, c->hostname);
        return -1;
@@ -113,6 +105,9 @@ cp
       return -1;
     }
 
+  if(seen_request(c->buffer))
+    return 0;
+
   /* Lookup nodes */
 
   from = lookup_node(from_name);
@@ -135,9 +130,7 @@ cp
 
   /* Convert addresses */
   
-  from_tcpaddress = str2sockaddr(from_address, from_tcpport);
   from_udpaddress = str2sockaddr(from_address, from_udpport);
-  to_tcpaddress = str2sockaddr(to_address, to_tcpport);
   to_udpaddress = str2sockaddr(to_address, to_udpport);
 
   /* Check if edge already exists */
@@ -147,8 +140,8 @@ cp
   if(e)
   {
     if(e->weight != weight || e->options != options
-       || ((e->from.node == from) && (sockaddrcmp(&e->from.tcpaddress, &from_tcpaddress) || sockaddrcmp(&e->from.udpaddress, &from_udpaddress) || sockaddrcmp(&e->to.tcpaddress, &to_tcpaddress) || sockaddrcmp(&e->to.udpaddress, &to_udpaddress)))
-       || ((e->from.node == to) && (sockaddrcmp(&e->from.tcpaddress, &to_tcpaddress) || sockaddrcmp(&e->from.udpaddress, &to_udpaddress) || sockaddrcmp(&e->to.tcpaddress, &from_tcpaddress) || sockaddrcmp(&e->to.udpaddress, &from_udpaddress)))
+       || ((e->from.node == from) && (sockaddrcmp(&e->from.udpaddress, &from_udpaddress)|| sockaddrcmp(&e->to.udpaddress, &to_udpaddress)))
+       || ((e->from.node == to) && (sockaddrcmp(&e->from.udpaddress, &to_udpaddress) || sockaddrcmp(&e->to.udpaddress, &from_udpaddress)))
       )
     {
       if(from == myself || to == myself)
@@ -180,14 +173,10 @@ cp
     return 0;
   }
 
-
-
   e = new_edge();
   e->from.node = from;
-  e->from.tcpaddress = from_tcpaddress;
   e->from.udpaddress = from_udpaddress;
   e->to.node = to;
-  e->to.tcpaddress = to_tcpaddress;
   e->to.udpaddress = to_udpaddress;
   e->options = options;
   e->weight = weight;
@@ -199,7 +188,7 @@ cp
     {
       other = (connection_t *)node->data;
       if(other->status.active && other != c)
-        send_add_edge(other, e);
+        send_request(other, "%s", c->buffer);
     }
 
   /* Run MST before or after we tell the rest? */
@@ -212,7 +201,7 @@ cp
 int send_del_edge(connection_t *c, edge_t *e)
 {
 cp
-  return send_request(c, "%d %s %s", DEL_EDGE,
+  return send_request(c, "%d %lx %s %s", DEL_EDGE, random(),
                       e->from.node->name, e->to.node->name);
 }
 
@@ -225,7 +214,7 @@ int del_edge_h(connection_t *c)
   connection_t *other;
   avl_node_t *node;
 cp
-  if(sscanf(c->buffer, "%*d "MAX_STRING" "MAX_STRING"", from_name, to_name) != 2)
+  if(sscanf(c->buffer, "%*d %*x "MAX_STRING" "MAX_STRING"", from_name, to_name) != 2)
     {
       syslog(LOG_ERR, _("Got bad %s from %s (%s)"), "DEL_EDGE",
              c->name, c->hostname);
@@ -246,6 +235,9 @@ cp
       return -1;
     }
 
+  if(seen_request(c->buffer))
+    return 0;
+
   /* Lookup nodes */
 
   from = lookup_node(from_name);
@@ -291,7 +283,7 @@ cp
     {
       other = (connection_t *)node->data;
       if(other->status.active && other != c)
-        send_del_edge(other, e);
+        send_request(other, "%s", c->buffer);
     }
 
   /* Delete the edge */