First round of needed fixes after the overhaul

[tinc] / src / netutl.c

diff --git a/src/netutl.c b/src/netutl.c
index fc53aae..5f76292 100644 (file)
--- a/src/netutl.c
+++ b/src/netutl.c
@@ -1,6 +1,6 @@
 /*
     netutl.c -- some supporting network utility code
-    Copyright (C) 1998,99 Ivo Timmermans <zarq@iname.com>
+    Copyright (C) 1998,1999,2000 Ivo Timmermans <itimmermans@bigfoot.com>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
@@ -15,6 +15,8 @@
     You should have received a copy of the GNU General Public License
     along with this program; if not, write to the Free Software
     Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+
+    $Id: netutl.c,v 1.12.4.9 2000/09/14 21:51:20 zarq Exp $
 */
 
 #include "config.h"
@@ -31,24 +33,29 @@
 #include <utils.h>
 #include <xalloc.h>
 
+#include "errno.h"
+#include "conf.h"
 #include "encr.h"
 #include "net.h"
 #include "netutl.h"
 
+#include "system.h"
+
 /*
   look for a connection associated with the given vpn ip,
-  return its connection structure
+  return its connection structure.
+  Skips connections that are not activated!
 */
 conn_list_t *lookup_conn(ip_t ip)
 {
   conn_list_t *p = conn_list;
-
+cp
   /* Exact match suggested by James B. MacLean */
   for(p = conn_list; p != NULL; p = p->next)
-    if(ip  == p->vpn_ip)
+    if((ip == p->vpn_ip) && p->status.active)
       return p;
   for(p = conn_list; p != NULL; p = p->next)
-    if((ip & p->vpn_mask) == (p->vpn_ip & p->vpn_mask))
+    if(((ip & p->vpn_mask) == (p->vpn_ip & p->vpn_mask)) && p->status.active)
       return p;
 cp
   return NULL;
@@ -79,14 +86,14 @@ cp
 void free_conn_element(conn_list_t *p)
 {
 cp
-  if(p->hostname)
-    free(p->hostname);
-  if(p->pp)
-    free(p->pp);
   if(p->sq)
     destroy_queue(p->sq);
   if(p->rq)
     destroy_queue(p->rq);
+  if(p->name)
+    free(p->name);
+  if(p->hostname)
+    free(p->hostname);
   free_key(p->public_key);
   free_key(p->key);
   free(p);
@@ -160,25 +167,32 @@ cp
   look up the name associated with the ip
   address `addr'
 */
+
 char *hostlookup(unsigned long addr)
 {
   char *name;
   struct hostent *host = NULL;
   struct in_addr in;
+  config_t const *cfg;
+  int lookup_hostname;
 cp
   in.s_addr = addr;
 
-  host = gethostbyaddr((char *)&in, sizeof(in), AF_INET);
+  lookup_hostname = 0;
+  if((cfg = get_config_val(resolve_dns)) != NULL)
+    if(cfg->data.val == stupid_true)
+      lookup_hostname = 1;
+
+  if(lookup_hostname)
+    host = gethostbyaddr((char *)&in, sizeof(in), AF_INET);
 
-  if(host)
+  if(!lookup_hostname || !host)
     {
-      name = xmalloc(strlen(host->h_name)+20);
-      sprintf(name, "%s (%s)", host->h_name, inet_ntoa(in));
+      asprintf(&name, "%s", inet_ntoa(in));
     }
   else
     {
-      name = xmalloc(20);
-      sprintf(name, "%s", inet_ntoa(in));
+      asprintf(&name, "%s", host->h_name);
     }
 cp
   return name;
@@ -204,7 +218,7 @@ cp
 
   if(!(h = gethostbyname(p)))
     {
-      fprintf(stderr, "Error looking up `%s': %s\n", p, sys_errlist[h_errno]);
+      fprintf(stderr, _("Error looking up `%s': %s\n"), p, strerror(errno));
       return NULL;
     }
 
@@ -228,13 +242,13 @@ void dump_conn_list(void)
 {
   conn_list_t *p;
 cp
-  syslog(LOG_DEBUG, "Connection list:");
+  syslog(LOG_DEBUG, _("Connection list:"));
 
   for(p = conn_list; p != NULL; p = p->next)
     {
-      syslog(LOG_DEBUG, " " IP_ADDR_S "/" IP_ADDR_S ": %04x (%d|%d)",
-            IP_ADDR_V(p->vpn_ip), IP_ADDR_V(p->vpn_mask), p->status,
-            p->socket, p->meta_socket);
+      syslog(LOG_DEBUG, _("%s netmask %d.%d.%d.%d at %s port %hd flags %d sockets %d, %d status %04x"),
+            p->name, IP_ADDR_V(p->vpn_mask), p->hostname, p->port, p->flags,
+            p->socket, p->meta_socket, p->status);
     }
 cp
 }