Add some missing freeaddrinfo() calls to avoid leaking memory.
[tinc] / src / net_setup.c
index daa296b..17675ae 100644 (file)
@@ -1,7 +1,7 @@
 /*
     net_setup.c -- Setup.
     Copyright (C) 1998-2005 Ivo Timmermans,
-                  2000-2013 Guus Sliepen <guus@tinc-vpn.org>
+                  2000-2017 Guus Sliepen <guus@tinc-vpn.org>
                   2006      Scott Lamb <slamb@slamb.org>
                   2010      Brandon Black <blblack@gmail.com>
 
 #include "utils.h"
 #include "xalloc.h"
 
+#ifdef HAVE_MINIUPNPC
+#include "upnp.h"
+#endif
+
 char *myport;
 static io_t device_io;
 devops_t devops;
+bool device_standby = false;
 
 char *proxyhost;
 char *proxyport;
 char *proxyuser;
 char *proxypass;
 proxytype_t proxytype;
-int autoconnect;
+bool autoconnect;
 bool disablebuggypeers;
 
 char *scriptinterpreter;
 char *scriptextension;
 
 bool node_read_ecdsa_public_key(node_t *n) {
-       if(ecdsa_active(n->ecdsa))
+       if(ecdsa_active(n->ecdsa)) {
                return true;
+       }
 
        splay_tree_t *config_tree;
        FILE *fp;
@@ -68,26 +74,30 @@ bool node_read_ecdsa_public_key(node_t *n) {
        char *p;
 
        init_configuration(&config_tree);
-       if(!read_host_config(config_tree, n->name))
+
+       if(!read_host_config(config_tree, n->name, true)) {
                goto exit;
+       }
 
-       /* First, check for simple ECDSAPublicKey statement */
+       /* First, check for simple Ed25519PublicKey statement */
 
-       if(get_config_string(lookup_config(config_tree, "ECDSAPublicKey"), &p)) {
+       if(get_config_string(lookup_config(config_tree, "Ed25519PublicKey"), &p)) {
                n->ecdsa = ecdsa_set_base64_public_key(p);
                free(p);
                goto exit;
        }
 
-       /* Else, check for ECDSAPublicKeyFile statement and read it */
+       /* Else, check for Ed25519PublicKeyFile statement and read it */
 
-       if(!get_config_string(lookup_config(config_tree, "ECDSAPublicKeyFile"), &pubname))
+       if(!get_config_string(lookup_config(config_tree, "Ed25519PublicKeyFile"), &pubname)) {
                xasprintf(&pubname, "%s" SLASH "hosts" SLASH "%s", confbase, n->name);
+       }
 
        fp = fopen(pubname, "r");
 
-       if(!fp)
+       if(!fp) {
                goto exit;
+       }
 
        n->ecdsa = ecdsa_read_pem_public_key(fp);
        fclose(fp);
@@ -99,8 +109,9 @@ exit:
 }
 
 bool read_ecdsa_public_key(connection_t *c) {
-       if(ecdsa_active(c->ecdsa))
+       if(ecdsa_active(c->ecdsa)) {
                return true;
+       }
 
        FILE *fp;
        char *fname;
@@ -108,45 +119,48 @@ bool read_ecdsa_public_key(connection_t *c) {
 
        if(!c->config_tree) {
                init_configuration(&c->config_tree);
-               if(!read_host_config(c->config_tree, c->name))
+
+               if(!read_host_config(c->config_tree, c->name, true)) {
                        return false;
+               }
        }
 
-       /* First, check for simple ECDSAPublicKey statement */
+       /* First, check for simple Ed25519PublicKey statement */
 
-       if(get_config_string(lookup_config(c->config_tree, "ECDSAPublicKey"), &p)) {
+       if(get_config_string(lookup_config(c->config_tree, "Ed25519PublicKey"), &p)) {
                c->ecdsa = ecdsa_set_base64_public_key(p);
                free(p);
                return c->ecdsa;
        }
 
-       /* Else, check for ECDSAPublicKeyFile statement and read it */
+       /* Else, check for Ed25519PublicKeyFile statement and read it */
 
-       if(!get_config_string(lookup_config(c->config_tree, "ECDSAPublicKeyFile"), &fname))
+       if(!get_config_string(lookup_config(c->config_tree, "Ed25519PublicKeyFile"), &fname)) {
                xasprintf(&fname, "%s" SLASH "hosts" SLASH "%s", confbase, c->name);
+       }
 
        fp = fopen(fname, "r");
 
        if(!fp) {
-               logger(DEBUG_ALWAYS, LOG_ERR, "Error reading ECDSA public key file `%s': %s",
-                          fname, strerror(errno));
+               logger(DEBUG_ALWAYS, LOG_ERR, "Error reading Ed25519 public key file `%s': %s",
+                      fname, strerror(errno));
                free(fname);
                return false;
        }
 
        c->ecdsa = ecdsa_read_pem_public_key(fp);
-       fclose(fp);
 
-       if(!c->ecdsa)
-               logger(DEBUG_ALWAYS, LOG_ERR, "Parsing ECDSA public key file `%s' failed.", fname);
+       if(!c->ecdsa && errno != ENOENT) {
+               logger(DEBUG_ALWAYS, LOG_ERR, "Parsing Ed25519 public key file `%s' failed.", fname);
+       }
+
+       fclose(fp);
        free(fname);
        return c->ecdsa;
 }
 
+#ifndef DISABLE_LEGACY
 bool read_rsa_public_key(connection_t *c) {
-       if(ecdsa_active(c->ecdsa))
-               return true;
-
        FILE *fp;
        char *fname;
        char *n;
@@ -161,8 +175,9 @@ bool read_rsa_public_key(connection_t *c) {
 
        /* Else, check for PublicKeyFile statement and read it */
 
-       if(!get_config_string(lookup_config(c->config_tree, "PublicKeyFile"), &fname))
+       if(!get_config_string(lookup_config(c->config_tree, "PublicKeyFile"), &fname)) {
                xasprintf(&fname, "%s" SLASH "hosts" SLASH "%s", confbase, c->name);
+       }
 
        fp = fopen(fname, "r");
 
@@ -175,11 +190,14 @@ bool read_rsa_public_key(connection_t *c) {
        c->rsa = rsa_read_pem_public_key(fp);
        fclose(fp);
 
-       if(!c->rsa)
+       if(!c->rsa) {
                logger(DEBUG_ALWAYS, LOG_ERR, "Reading RSA public key file `%s' failed: %s", fname, strerror(errno));
+       }
+
        free(fname);
        return c->rsa;
 }
+#endif
 
 static bool read_ecdsa_private_key(void) {
        FILE *fp;
@@ -187,15 +205,19 @@ static bool read_ecdsa_private_key(void) {
 
        /* Check for PrivateKeyFile statement and read it */
 
-       if(!get_config_string(lookup_config(config_tree, "ECDSAPrivateKeyFile"), &fname))
-               xasprintf(&fname, "%s" SLASH "ecdsa_key.priv", confbase);
+       if(!get_config_string(lookup_config(config_tree, "Ed25519PrivateKeyFile"), &fname)) {
+               xasprintf(&fname, "%s" SLASH "ed25519_key.priv", confbase);
+       }
 
        fp = fopen(fname, "r");
 
        if(!fp) {
-               logger(DEBUG_ALWAYS, LOG_ERR, "Error reading ECDSA private key file `%s': %s", fname, strerror(errno));
-               if(errno == ENOENT)
-                       logger(DEBUG_ALWAYS, LOG_INFO, "Create an ECDSA keypair with `tinc -n %s generate-ecdsa-keys'.", netname ?: ".");
+               logger(DEBUG_ALWAYS, LOG_ERR, "Error reading Ed25519 private key file `%s': %s", fname, strerror(errno));
+
+               if(errno == ENOENT) {
+                       logger(DEBUG_ALWAYS, LOG_INFO, "Create an Ed25519 keypair with `tinc -n %s generate-ed25519-keys'.", netname ? : ".");
+               }
+
                free(fname);
                return false;
        }
@@ -204,48 +226,54 @@ static bool read_ecdsa_private_key(void) {
        struct stat s;
 
        if(fstat(fileno(fp), &s)) {
-               logger(DEBUG_ALWAYS, LOG_ERR, "Could not stat ECDSA private key file `%s': %s'", fname, strerror(errno));
+               logger(DEBUG_ALWAYS, LOG_ERR, "Could not stat Ed25519 private key file `%s': %s'", fname, strerror(errno));
                free(fname);
                return false;
        }
 
-       if(s.st_mode & ~0100700)
-               logger(DEBUG_ALWAYS, LOG_WARNING, "Warning: insecure file permissions for ECDSA private key file `%s'!", fname);
+       if(s.st_mode & ~0100700) {
+               logger(DEBUG_ALWAYS, LOG_WARNING, "Warning: insecure file permissions for Ed25519 private key file `%s'!", fname);
+       }
+
 #endif
 
        myself->connection->ecdsa = ecdsa_read_pem_private_key(fp);
        fclose(fp);
 
-       if(!myself->connection->ecdsa)
-               logger(DEBUG_ALWAYS, LOG_ERR, "Reading ECDSA private key file `%s' failed: %s", fname, strerror(errno));
+       if(!myself->connection->ecdsa) {
+               logger(DEBUG_ALWAYS, LOG_ERR, "Reading Ed25519 private key file `%s' failed", fname);
+       }
+
        free(fname);
        return myself->connection->ecdsa;
 }
 
 static bool read_invitation_key(void) {
        FILE *fp;
-       char *fname;
+       char fname[PATH_MAX];
 
        if(invitation_key) {
                ecdsa_free(invitation_key);
                invitation_key = NULL;
        }
 
-       xasprintf(&fname, "%s" SLASH "invitations" SLASH "ecdsa_key.priv", confbase);
+       snprintf(fname, sizeof(fname), "%s" SLASH "invitations" SLASH "ed25519_key.priv", confbase);
 
        fp = fopen(fname, "r");
 
        if(fp) {
                invitation_key = ecdsa_read_pem_private_key(fp);
                fclose(fp);
-               if(!invitation_key)
-                       logger(DEBUG_ALWAYS, LOG_ERR, "Reading ECDSA private key file `%s' failed: %s", fname, strerror(errno));
+
+               if(!invitation_key) {
+                       logger(DEBUG_ALWAYS, LOG_ERR, "Reading Ed25519 private key file `%s' failed", fname);
+               }
        }
 
-       free(fname);
        return invitation_key;
 }
 
+#ifndef DISABLE_LEGACY
 static bool read_rsa_private_key(void) {
        FILE *fp;
        char *fname;
@@ -259,6 +287,7 @@ static bool read_rsa_private_key(void) {
                        free(d);
                        return false;
                }
+
                myself->connection->rsa = rsa_set_hex_private_key(n, "FFFF", d);
                free(n);
                free(d);
@@ -267,14 +296,20 @@ static bool read_rsa_private_key(void) {
 
        /* Else, check for PrivateKeyFile statement and read it */
 
-       if(!get_config_string(lookup_config(config_tree, "PrivateKeyFile"), &fname))
+       if(!get_config_string(lookup_config(config_tree, "PrivateKeyFile"), &fname)) {
                xasprintf(&fname, "%s" SLASH "rsa_key.priv", confbase);
+       }
 
        fp = fopen(fname, "r");
 
        if(!fp) {
                logger(DEBUG_ALWAYS, LOG_ERR, "Error reading RSA private key file `%s': %s",
-                          fname, strerror(errno));
+                      fname, strerror(errno));
+
+               if(errno == ENOENT) {
+                       logger(DEBUG_ALWAYS, LOG_INFO, "Create an RSA keypair with `tinc -n %s generate-rsa-keys'.", netname ? : ".");
+               }
+
                free(fname);
                return false;
        }
@@ -288,61 +323,66 @@ static bool read_rsa_private_key(void) {
                return false;
        }
 
-       if(s.st_mode & ~0100700)
+       if(s.st_mode & ~0100700) {
                logger(DEBUG_ALWAYS, LOG_WARNING, "Warning: insecure file permissions for RSA private key file `%s'!", fname);
+       }
+
 #endif
 
        myself->connection->rsa = rsa_read_pem_private_key(fp);
        fclose(fp);
 
-       if(!myself->connection->rsa)
+       if(!myself->connection->rsa) {
                logger(DEBUG_ALWAYS, LOG_ERR, "Reading RSA private key file `%s' failed: %s", fname, strerror(errno));
+       }
+
        free(fname);
        return myself->connection->rsa;
 }
+#endif
 
 static timeout_t keyexpire_timeout;
 
 static void keyexpire_handler(void *data) {
        regenerate_key();
-       timeout_set(data, &(struct timeval){keylifetime, rand() % 100000});
+       timeout_set(data, &(struct timeval) {
+               keylifetime, rand() % 100000
+       });
 }
 
 void regenerate_key(void) {
        logger(DEBUG_STATUS, LOG_INFO, "Expiring symmetric keys");
        send_key_changed();
+
+       for splay_each(node_t, n, node_tree) {
+               n->status.validkey_in = false;
+       }
 }
 
-/*
-  Read Subnets from all host config files
-*/
-void load_all_subnets(void) {
+void load_all_nodes(void) {
        DIR *dir;
        struct dirent *ent;
-       char *dname;
+       char dname[PATH_MAX];
 
-       xasprintf(&dname, "%s" SLASH "hosts", confbase);
+       snprintf(dname, sizeof(dname), "%s" SLASH "hosts", confbase);
        dir = opendir(dname);
+
        if(!dir) {
                logger(DEBUG_ALWAYS, LOG_ERR, "Could not open %s: %s", dname, strerror(errno));
-               free(dname);
                return;
        }
 
        while((ent = readdir(dir))) {
-               if(!check_id(ent->d_name))
+               if(!check_id(ent->d_name)) {
                        continue;
+               }
 
                node_t *n = lookup_node(ent->d_name);
-               #ifdef _DIRENT_HAVE_D_TYPE
-               //if(ent->d_type != DT_REG)
-               //      continue;
-               #endif
 
                splay_tree_t *config_tree;
                init_configuration(&config_tree);
                read_config_options(config_tree, ent->d_name);
-               read_host_config(config_tree, ent->d_name);
+               read_host_config(config_tree, ent->d_name, true);
 
                if(!n) {
                        n = new_node();
@@ -350,92 +390,46 @@ void load_all_subnets(void) {
                        node_add(n);
                }
 
-               for(config_t *cfg = lookup_config(config_tree, "Subnet"); cfg; cfg = lookup_config_next(config_tree, cfg)) {
-                       subnet_t *s, *s2;
+               if(strictsubnets) {
+                       for(config_t *cfg = lookup_config(config_tree, "Subnet"); cfg; cfg = lookup_config_next(config_tree, cfg)) {
+                               subnet_t *s, *s2;
 
-                       if(!get_config_subnet(cfg, &s))
-                               continue;
+                               if(!get_config_subnet(cfg, &s)) {
+                                       continue;
+                               }
 
-                       if((s2 = lookup_subnet(n, s))) {
-                               s2->expires = -1;
-                       } else {
-                               subnet_add(n, s);
+                               if((s2 = lookup_subnet(n, s))) {
+                                       s2->expires = -1;
+                                       free(s);
+                               } else {
+                                       subnet_add(n, s);
+                               }
                        }
                }
 
-               exit_configuration(&config_tree);
-       }
-
-       closedir(dir);
-}
-
-void load_all_nodes(void) {
-       DIR *dir;
-       struct dirent *ent;
-       char *dname;
-
-       xasprintf(&dname, "%s" SLASH "hosts", confbase);
-       dir = opendir(dname);
-       if(!dir) {
-               logger(DEBUG_ALWAYS, LOG_ERR, "Could not open %s: %s", dname, strerror(errno));
-               free(dname);
-               return;
-       }
-
-       while((ent = readdir(dir))) {
-               if(!check_id(ent->d_name))
-                       continue;
-
-               node_t *n = lookup_node(ent->d_name);
-               if(n)
-                       continue;
+               if(lookup_config(config_tree, "Address")) {
+                       n->status.has_address = true;
+               }
 
-               n = new_node();
-               n->name = xstrdup(ent->d_name);
-               node_add(n);
+               exit_configuration(&config_tree);
        }
 
        closedir(dir);
 }
 
-
 char *get_name(void) {
        char *name = NULL;
+       char *returned_name;
 
        get_config_string(lookup_config(config_tree, "Name"), &name);
 
-       if(!name)
+       if(!name) {
                return NULL;
-
-       if(*name == '$') {
-               char *envname = getenv(name + 1);
-               char hostname[32] = "";
-               if(!envname) {
-                       if(strcmp(name + 1, "HOST")) {
-                               logger(DEBUG_ALWAYS, LOG_ERR, "Invalid Name: environment variable %s does not exist\n", name + 1);
-                               return false;
-                       }
-                       if(gethostname(hostname, sizeof hostname) || !*hostname) {
-                               logger(DEBUG_ALWAYS, LOG_ERR, "Could not get hostname: %s\n", strerror(errno));
-                               return false;
-                       }
-                       hostname[31] = 0;
-                       envname = hostname;
-               }
-               free(name);
-               name = xstrdup(envname);
-               for(char *c = name; *c; c++)
-                       if(!isalnum(*c))
-                               *c = '_';
-       }
-
-       if(!check_id(name)) {
-               logger(DEBUG_ALWAYS, LOG_ERR, "Invalid name for myself!");
-               free(name);
-               return false;
        }
 
-       return name;
+       returned_name = replace_name(name);
+       free(name);
+       return returned_name;
 }
 
 bool setup_myself_reloadable(void) {
@@ -444,7 +438,6 @@ bool setup_myself_reloadable(void) {
        char *fmode = NULL;
        char *bmode = NULL;
        char *afname = NULL;
-       char *address = NULL;
        char *space;
        bool choice;
 
@@ -454,13 +447,17 @@ bool setup_myself_reloadable(void) {
 
 
        free(scriptextension);
-       if(!get_config_string(lookup_config(config_tree, "ScriptsExtension"), &scriptextension))
+
+       if(!get_config_string(lookup_config(config_tree, "ScriptsExtension"), &scriptextension)) {
                scriptextension = xstrdup("");
+       }
 
        get_config_string(lookup_config(config_tree, "Proxy"), &proxy);
+
        if(proxy) {
-               if((space = strchr(proxy, ' ')))
+               if((space = strchr(proxy, ' '))) {
                        *space++ = 0;
+               }
 
                if(!strcasecmp(proxy, "none")) {
                        proxytype = PROXY_NONE;
@@ -480,162 +477,233 @@ bool setup_myself_reloadable(void) {
                }
 
                switch(proxytype) {
-                       case PROXY_NONE:
-                       default:
-                               break;
+               case PROXY_NONE:
+               default:
+                       break;
 
-                       case PROXY_EXEC:
-                               if(!space || !*space) {
-                                       logger(DEBUG_ALWAYS, LOG_ERR, "Argument expected for proxy type exec!");
-                                       return false;
-                               }
-                               proxyhost =  xstrdup(space);
-                               break;
+               case PROXY_EXEC:
+                       if(!space || !*space) {
+                               logger(DEBUG_ALWAYS, LOG_ERR, "Argument expected for proxy type exec!");
+                               return false;
+                       }
 
-                       case PROXY_SOCKS4:
-                       case PROXY_SOCKS4A:
-                       case PROXY_SOCKS5:
-                       case PROXY_HTTP:
-                               proxyhost = space;
-                               if(space && (space = strchr(space, ' ')))
-                                       *space++ = 0, proxyport = space;
-                               if(space && (space = strchr(space, ' ')))
-                                       *space++ = 0, proxyuser = space;
-                               if(space && (space = strchr(space, ' ')))
-                                       *space++ = 0, proxypass = space;
-                               if(!proxyhost || !*proxyhost || !proxyport || !*proxyport) {
-                                       logger(DEBUG_ALWAYS, LOG_ERR, "Host and port argument expected for proxy!");
-                                       return false;
-                               }
-                               proxyhost = xstrdup(proxyhost);
-                               proxyport = xstrdup(proxyport);
-                               if(proxyuser && *proxyuser)
-                                       proxyuser = xstrdup(proxyuser);
-                               if(proxypass && *proxypass)
-                                       proxypass = xstrdup(proxypass);
-                               break;
+                       proxyhost =  xstrdup(space);
+                       break;
+
+               case PROXY_SOCKS4:
+               case PROXY_SOCKS4A:
+               case PROXY_SOCKS5:
+               case PROXY_HTTP:
+                       proxyhost = space;
+
+                       if(space && (space = strchr(space, ' '))) {
+                               *space++ = 0, proxyport = space;
+                       }
+
+                       if(space && (space = strchr(space, ' '))) {
+                               *space++ = 0, proxyuser = space;
+                       }
+
+                       if(space && (space = strchr(space, ' '))) {
+                               *space++ = 0, proxypass = space;
+                       }
+
+                       if(!proxyhost || !*proxyhost || !proxyport || !*proxyport) {
+                               logger(DEBUG_ALWAYS, LOG_ERR, "Host and port argument expected for proxy!");
+                               return false;
+                       }
+
+                       proxyhost = xstrdup(proxyhost);
+                       proxyport = xstrdup(proxyport);
+
+                       if(proxyuser && *proxyuser) {
+                               proxyuser = xstrdup(proxyuser);
+                       }
+
+                       if(proxypass && *proxypass) {
+                               proxypass = xstrdup(proxypass);
+                       }
+
+                       break;
                }
 
                free(proxy);
        }
 
-       if(get_config_bool(lookup_config(config_tree, "IndirectData"), &choice) && choice)
+       if(get_config_bool(lookup_config(config_tree, "IndirectData"), &choice) && choice) {
                myself->options |= OPTION_INDIRECT;
+       }
 
-       if(get_config_bool(lookup_config(config_tree, "TCPOnly"), &choice) && choice)
+       if(get_config_bool(lookup_config(config_tree, "TCPOnly"), &choice) && choice) {
                myself->options |= OPTION_TCPONLY;
+       }
 
-       if(myself->options & OPTION_TCPONLY)
+       if(myself->options & OPTION_TCPONLY) {
                myself->options |= OPTION_INDIRECT;
+       }
 
-       get_config_bool(lookup_config(config_tree, "DirectOnly"), &directonly);
-       get_config_bool(lookup_config(config_tree, "LocalDiscovery"), &localdiscovery);
+       get_config_bool(lookup_config(config_tree, "UDPDiscovery"), &udp_discovery);
+       get_config_int(lookup_config(config_tree, "UDPDiscoveryKeepaliveInterval"), &udp_discovery_keepalive_interval);
+       get_config_int(lookup_config(config_tree, "UDPDiscoveryInterval"), &udp_discovery_interval);
+       get_config_int(lookup_config(config_tree, "UDPDiscoveryTimeout"), &udp_discovery_timeout);
 
-       memset(&localdiscovery_address, 0, sizeof localdiscovery_address);
-       if(get_config_string(lookup_config(config_tree, "LocalDiscoveryAddress"), &address)) {
-               struct addrinfo *ai = str2addrinfo(address, myport, SOCK_DGRAM);
-               free(address);
-               if(!ai)
-                       return false;
-               memcpy(&localdiscovery_address, ai->ai_addr, ai->ai_addrlen);
-       }
+       get_config_int(lookup_config(config_tree, "MTUInfoInterval"), &mtu_info_interval);
+       get_config_int(lookup_config(config_tree, "UDPInfoInterval"), &udp_info_interval);
 
+       get_config_bool(lookup_config(config_tree, "DirectOnly"), &directonly);
+       get_config_bool(lookup_config(config_tree, "LocalDiscovery"), &localdiscovery);
 
        if(get_config_string(lookup_config(config_tree, "Mode"), &rmode)) {
-               if(!strcasecmp(rmode, "router"))
+               if(!strcasecmp(rmode, "router")) {
                        routing_mode = RMODE_ROUTER;
-               else if(!strcasecmp(rmode, "switch"))
+               } else if(!strcasecmp(rmode, "switch")) {
                        routing_mode = RMODE_SWITCH;
-               else if(!strcasecmp(rmode, "hub"))
+               } else if(!strcasecmp(rmode, "hub")) {
                        routing_mode = RMODE_HUB;
-               else {
+               else {
                        logger(DEBUG_ALWAYS, LOG_ERR, "Invalid routing mode!");
                        return false;
                }
+
                free(rmode);
        }
 
        if(get_config_string(lookup_config(config_tree, "Forwarding"), &fmode)) {
-               if(!strcasecmp(fmode, "off"))
+               if(!strcasecmp(fmode, "off")) {
                        forwarding_mode = FMODE_OFF;
-               else if(!strcasecmp(fmode, "internal"))
+               } else if(!strcasecmp(fmode, "internal")) {
                        forwarding_mode = FMODE_INTERNAL;
-               else if(!strcasecmp(fmode, "kernel"))
+               } else if(!strcasecmp(fmode, "kernel")) {
                        forwarding_mode = FMODE_KERNEL;
-               else {
+               else {
                        logger(DEBUG_ALWAYS, LOG_ERR, "Invalid forwarding mode!");
                        return false;
                }
+
                free(fmode);
        }
 
-       choice = true;
+       choice = !(myself->options & OPTION_TCPONLY);
        get_config_bool(lookup_config(config_tree, "PMTUDiscovery"), &choice);
-       if(choice)
+
+       if(choice) {
                myself->options |= OPTION_PMTU_DISCOVERY;
+       }
 
        choice = true;
        get_config_bool(lookup_config(config_tree, "ClampMSS"), &choice);
-       if(choice)
+
+       if(choice) {
                myself->options |= OPTION_CLAMP_MSS;
+       }
 
        get_config_bool(lookup_config(config_tree, "PriorityInheritance"), &priorityinheritance);
        get_config_bool(lookup_config(config_tree, "DecrementTTL"), &decrement_ttl);
+
        if(get_config_string(lookup_config(config_tree, "Broadcast"), &bmode)) {
-               if(!strcasecmp(bmode, "no"))
+               if(!strcasecmp(bmode, "no")) {
                        broadcast_mode = BMODE_NONE;
-               else if(!strcasecmp(bmode, "yes") || !strcasecmp(bmode, "mst"))
+               } else if(!strcasecmp(bmode, "yes") || !strcasecmp(bmode, "mst")) {
                        broadcast_mode = BMODE_MST;
-               else if(!strcasecmp(bmode, "direct"))
+               } else if(!strcasecmp(bmode, "direct")) {
                        broadcast_mode = BMODE_DIRECT;
-               else {
+               else {
                        logger(DEBUG_ALWAYS, LOG_ERR, "Invalid broadcast mode!");
                        return false;
                }
+
                free(bmode);
        }
 
-#if !defined(SOL_IP) || !defined(IP_TOS)
-       if(priorityinheritance)
-               logger(DEBUG_ALWAYS, LOG_WARNING, "%s not supported on this platform", "PriorityInheritance");
+       const char *const DEFAULT_BROADCAST_SUBNETS[] = { "ff:ff:ff:ff:ff:ff", "255.255.255.255", "224.0.0.0/4", "ff00::/8" };
+
+       for(size_t i = 0; i < sizeof(DEFAULT_BROADCAST_SUBNETS) / sizeof(*DEFAULT_BROADCAST_SUBNETS); i++) {
+               subnet_t *s = new_subnet();
+
+               if(!str2net(s, DEFAULT_BROADCAST_SUBNETS[i])) {
+                       abort();
+               }
+
+               subnet_add(NULL, s);
+       }
+
+       for(config_t *cfg = lookup_config(config_tree, "BroadcastSubnet"); cfg; cfg = lookup_config_next(config_tree, cfg)) {
+               subnet_t *s;
+
+               if(!get_config_subnet(cfg, &s)) {
+                       continue;
+               }
+
+               subnet_add(NULL, s);
+       }
+
+#if !defined(IP_TOS)
+
+       if(priorityinheritance) {
+               logger(DEBUG_ALWAYS, LOG_WARNING, "%s not supported on this platform for IPv4 connections", "PriorityInheritance");
+       }
+
+#endif
+
+#if !defined(IPV6_TCLASS)
+
+       if(priorityinheritance) {
+               logger(DEBUG_ALWAYS, LOG_WARNING, "%s not supported on this platform for IPv6 connections", "PriorityInheritance");
+       }
+
 #endif
 
-       if(!get_config_int(lookup_config(config_tree, "MACExpire"), &macexpire))
+       if(!get_config_int(lookup_config(config_tree, "MACExpire"), &macexpire)) {
                macexpire = 600;
+       }
 
        if(get_config_int(lookup_config(config_tree, "MaxTimeout"), &maxtimeout)) {
                if(maxtimeout <= 0) {
                        logger(DEBUG_ALWAYS, LOG_ERR, "Bogus maximum timeout!");
                        return false;
                }
-       } else
+       } else {
                maxtimeout = 900;
+       }
 
        if(get_config_string(lookup_config(config_tree, "AddressFamily"), &afname)) {
-               if(!strcasecmp(afname, "IPv4"))
+               if(!strcasecmp(afname, "IPv4")) {
                        addressfamily = AF_INET;
-               else if(!strcasecmp(afname, "IPv6"))
+               } else if(!strcasecmp(afname, "IPv6")) {
                        addressfamily = AF_INET6;
-               else if(!strcasecmp(afname, "any"))
+               } else if(!strcasecmp(afname, "any")) {
                        addressfamily = AF_UNSPEC;
-               else {
+               else {
                        logger(DEBUG_ALWAYS, LOG_ERR, "Invalid address family!");
                        return false;
                }
+
                free(afname);
        }
 
        get_config_bool(lookup_config(config_tree, "Hostnames"), &hostnames);
 
-       if(!get_config_int(lookup_config(config_tree, "KeyExpire"), &keylifetime))
+       if(!get_config_int(lookup_config(config_tree, "KeyExpire"), &keylifetime)) {
                keylifetime = 3600;
+       }
 
-       get_config_int(lookup_config(config_tree, "AutoConnect"), &autoconnect);
-       if(autoconnect < 0)
-               autoconnect = 0;
+       config_t *cfg = lookup_config(config_tree, "AutoConnect");
+
+       if(cfg) {
+               if(!get_config_bool(cfg, &autoconnect)) {
+                       // Some backwards compatibility with when this option was an int
+                       int val = 0;
+                       get_config_int(cfg, &val);
+                       autoconnect = val;
+               }
+       }
 
        get_config_bool(lookup_config(config_tree, "DisableBuggyPeers"), &disablebuggypeers);
 
+       if(!get_config_int(lookup_config(config_tree, "InvitationExpire"), &invitation_lifetime)) {
+               invitation_lifetime = 604800;        // 1 week
+       }
+
        read_invitation_key();
 
        return true;
@@ -649,22 +717,33 @@ static bool add_listen_address(char *address, bool bindto) {
 
        if(address) {
                char *space = strchr(address, ' ');
+
                if(space) {
                        *space++ = 0;
                        port = space;
                }
 
-               if(!strcmp(address, "*"))
+               if(!strcmp(address, "*")) {
                        *address = 0;
+               }
        }
 
        struct addrinfo *ai, hint = {0};
+
        hint.ai_family = addressfamily;
+
        hint.ai_socktype = SOCK_STREAM;
+
        hint.ai_protocol = IPPROTO_TCP;
+
        hint.ai_flags = AI_PASSIVE;
 
+#if HAVE_DECL_RES_INIT
+       res_init();
+
+#endif
        int err = getaddrinfo(address && *address ? address : NULL, port, &hint, &ai);
+
        free(address);
 
        if(err || !ai) {
@@ -682,8 +761,9 @@ static bool add_listen_address(char *address, bool bindto) {
                                break;
                        }
 
-               if(found)
+               if(found) {
                        continue;
+               }
 
                if(listen_sockets >= MAXSOCKETS) {
                        logger(DEBUG_ALWAYS, LOG_ERR, "Too many listening sockets");
@@ -692,12 +772,13 @@ static bool add_listen_address(char *address, bool bindto) {
 
                int tcp_fd = setup_listen_socket((sockaddr_t *) aip->ai_addr);
 
-               if(tcp_fd < 0)
+               if(tcp_fd < 0) {
                        continue;
+               }
 
                int udp_fd = setup_vpn_in_socket((sockaddr_t *) aip->ai_addr);
 
-               if(tcp_fd < 0) {
+               if(udp_fd < 0) {
                        close(tcp_fd);
                        continue;
                }
@@ -720,6 +801,30 @@ static bool add_listen_address(char *address, bool bindto) {
        return true;
 }
 
+void device_enable(void) {
+       if(devops.enable) {
+               devops.enable();
+       }
+
+       /* Run tinc-up script to further initialize the tap interface */
+
+       environment_t env;
+       environment_init(&env);
+       execute_script("tinc-up", &env);
+       environment_exit(&env);
+}
+
+void device_disable(void) {
+       environment_t env;
+       environment_init(&env);
+       execute_script("tinc-down", &env);
+       environment_exit(&env);
+
+       if(devops.disable) {
+               devops.disable();
+       }
+}
+
 /*
   Configure node_t myself and set up the local sockets (listen only)
 */
@@ -733,16 +838,18 @@ static bool setup_myself(void) {
                return false;
        }
 
+       myname = xstrdup(name);
        myself = new_node();
        myself->connection = new_connection();
        myself->name = name;
        myself->connection->name = xstrdup(name);
-       read_host_config(config_tree, name);
+       read_host_config(config_tree, name, true);
 
-       if(!get_config_string(lookup_config(config_tree, "Port"), &myport))
+       if(!get_config_string(lookup_config(config_tree, "Port"), &myport)) {
                myport = xstrdup("655");
-       else
+       } else {
                port_specified = true;
+       }
 
        myself->connection->options = 0;
        myself->connection->protocol_major = PROT_MAJOR;
@@ -750,27 +857,52 @@ static bool setup_myself(void) {
 
        myself->options |= PROT_MINOR << 24;
 
+#ifdef DISABLE_LEGACY
+       experimental = read_ecdsa_private_key();
+
+       if(!experimental) {
+               logger(DEBUG_ALWAYS, LOG_ERR, "No private key available, cannot start tinc!");
+               return false;
+       }
+
+#else
+
        if(!get_config_bool(lookup_config(config_tree, "ExperimentalProtocol"), &experimental)) {
                experimental = read_ecdsa_private_key();
-               if(!experimental)
+
+               if(!experimental) {
                        logger(DEBUG_ALWAYS, LOG_WARNING, "Support for SPTPS disabled.");
+               }
        } else {
-               if(experimental && !read_ecdsa_private_key())
+               if(experimental && !read_ecdsa_private_key()) {
                        return false;
+               }
        }
 
-       if(!read_rsa_private_key())
-               return false;
+       if(!read_rsa_private_key()) {
+               if(experimental) {
+                       logger(DEBUG_ALWAYS, LOG_WARNING, "Support for legacy protocol disabled.");
+               } else {
+                       logger(DEBUG_ALWAYS, LOG_ERR, "No private keys available, cannot start tinc!");
+                       return false;
+               }
+       }
+
+#endif
 
        /* Ensure myport is numeric */
 
        if(!atoi(myport)) {
                struct addrinfo *ai = str2addrinfo("localhost", myport, SOCK_DGRAM);
                sockaddr_t sa;
-               if(!ai || !ai->ai_addr)
+
+               if(!ai || !ai->ai_addr) {
                        return false;
+               }
+
                free(myport);
                memcpy(&sa, ai->ai_addr, ai->ai_addrlen);
+               freeaddrinfo(ai);
                sockaddr2str(&sa, NULL, &myport);
        }
 
@@ -779,16 +911,18 @@ static bool setup_myself(void) {
        for(config_t *cfg = lookup_config(config_tree, "Subnet"); cfg; cfg = lookup_config_next(config_tree, cfg)) {
                subnet_t *subnet;
 
-               if(!get_config_subnet(cfg, &subnet))
+               if(!get_config_subnet(cfg, &subnet)) {
                        return false;
+               }
 
                subnet_add(myself, subnet);
        }
 
        /* Check some options */
 
-       if(!setup_myself_reloadable())
+       if(!setup_myself_reloadable()) {
                return false;
+       }
 
        get_config_bool(lookup_config(config_tree, "StrictSubnets"), &strictsubnets);
        get_config_bool(lookup_config(config_tree, "TunnelServer"), &tunnelserver);
@@ -802,33 +936,37 @@ static bool setup_myself(void) {
        }
 
        if(get_config_int(lookup_config(config_tree, "UDPRcvBuf"), &udp_rcvbuf)) {
-               if(udp_rcvbuf <= 0) {
+               if(udp_rcvbuf < 0) {
                        logger(DEBUG_ALWAYS, LOG_ERR, "UDPRcvBuf cannot be negative!");
                        return false;
                }
        }
 
        if(get_config_int(lookup_config(config_tree, "UDPSndBuf"), &udp_sndbuf)) {
-               if(udp_sndbuf <= 0) {
+               if(udp_sndbuf < 0) {
                        logger(DEBUG_ALWAYS, LOG_ERR, "UDPSndBuf cannot be negative!");
                        return false;
                }
        }
 
        int replaywin_int;
+
        if(get_config_int(lookup_config(config_tree, "ReplayWindow"), &replaywin_int)) {
                if(replaywin_int < 0) {
                        logger(DEBUG_ALWAYS, LOG_ERR, "ReplayWindow cannot be negative!");
                        return false;
                }
+
                replaywin = (unsigned)replaywin_int;
                sptps_replaywin = replaywin;
        }
 
+#ifndef DISABLE_LEGACY
        /* Generate packet encryption key */
 
-       if(!get_config_string(lookup_config(config_tree, "Cipher"), &cipher))
-               cipher = xstrdup("blowfish");
+       if(!get_config_string(lookup_config(config_tree, "Cipher"), &cipher)) {
+               cipher = xstrdup("aes-256-cbc");
+       }
 
        if(!strcasecmp(cipher, "none")) {
                myself->incipher = NULL;
@@ -839,7 +977,9 @@ static bool setup_myself(void) {
 
        free(cipher);
 
-       timeout_add(&keyexpire_timeout, keyexpire_handler, &keyexpire_timeout, &(struct timeval){keylifetime, rand() % 100000});
+       timeout_add(&keyexpire_timeout, keyexpire_handler, &keyexpire_timeout, &(struct timeval) {
+               keylifetime, rand() % 100000
+       });
 
        /* Check if we want to use message authentication codes... */
 
@@ -851,8 +991,9 @@ static bool setup_myself(void) {
                return false;
        }
 
-       if(!get_config_string(lookup_config(config_tree, "Digest"), &digest))
-               digest = xstrdup("sha1");
+       if(!get_config_string(lookup_config(config_tree, "Digest"), &digest)) {
+               digest = xstrdup("sha256");
+       }
 
        if(!strcasecmp(digest, "none")) {
                myself->indigest = NULL;
@@ -862,6 +1003,7 @@ static bool setup_myself(void) {
        }
 
        free(digest);
+#endif
 
        /* Compression */
 
@@ -870,8 +1012,9 @@ static bool setup_myself(void) {
                        logger(DEBUG_ALWAYS, LOG_ERR, "Bogus compression level!");
                        return false;
                }
-       } else
+       } else {
                myself->incompression = 0;
+       }
 
        myself->connection->outcompression = 0;
 
@@ -886,37 +1029,47 @@ static bool setup_myself(void) {
 
        graph();
 
-       if(strictsubnets)
-               load_all_subnets();
-       else if(autoconnect)
-               load_all_nodes();
+       load_all_nodes();
 
        /* Open device */
 
        devops = os_devops;
 
        if(get_config_string(lookup_config(config_tree, "DeviceType"), &type)) {
-               if(!strcasecmp(type, "dummy"))
+               if(!strcasecmp(type, "dummy")) {
                        devops = dummy_devops;
-               else if(!strcasecmp(type, "raw_socket"))
+               } else if(!strcasecmp(type, "raw_socket")) {
                        devops = raw_socket_devops;
-               else if(!strcasecmp(type, "multicast"))
+               } else if(!strcasecmp(type, "multicast")) {
                        devops = multicast_devops;
+               } else if(!strcasecmp(type, "fd")) {
+                       devops = fd_devops;
+               }
+
 #ifdef ENABLE_UML
-               else if(!strcasecmp(type, "uml"))
+               else if(!strcasecmp(type, "uml")) {
                        devops = uml_devops;
+               }
+
 #endif
 #ifdef ENABLE_VDE
-               else if(!strcasecmp(type, "vde"))
+               else if(!strcasecmp(type, "vde")) {
                        devops = vde_devops;
+               }
+
 #endif
+               free(type);
        }
 
-       if(!devops.setup())
+       get_config_bool(lookup_config(config_tree, "DeviceStandby"), &device_standby);
+
+       if(!devops.setup()) {
                return false;
+       }
 
-       if(device_fd >= 0)
+       if(device_fd >= 0) {
                io_add(&device_io, handle_device_data, NULL, device_fd, IO_READ);
+       }
 
        /* Open sockets */
 
@@ -935,9 +1088,10 @@ static bool setup_myself(void) {
                }
 
                for(int i = 0; i < listen_sockets; i++) {
-                       salen = sizeof sa;
+                       salen = sizeof(sa);
+
                        if(getsockname(i + 3, &sa.sa, &salen) < 0) {
-                               logger(DEBUG_ALWAYS, LOG_ERR, "Could not get address of listen fd %d: %s", i + 3, sockstrerror(errno));
+                               logger(DEBUG_ALWAYS, LOG_ERR, "Could not get address of listen fd %d: %s", i + 3, sockstrerror(sockerrno));
                                return false;
                        }
 
@@ -946,8 +1100,10 @@ static bool setup_myself(void) {
 #endif
 
                        int udp_fd = setup_vpn_in_socket(&sa);
-                       if(udp_fd < 0)
+
+                       if(udp_fd < 0) {
                                return false;
+                       }
 
                        io_add(&listen_socket[i].tcp, (io_cb_t)handle_new_meta_connection, &listen_socket[i], i + 3, IO_READ);
                        io_add(&listen_socket[i].udp, (io_cb_t)handle_incoming_vpn_data, &listen_socket[i], udp_fd, IO_READ);
@@ -967,20 +1123,25 @@ static bool setup_myself(void) {
                for(config_t *cfg = lookup_config(config_tree, "BindToAddress"); cfg; cfg = lookup_config_next(config_tree, cfg)) {
                        cfgs++;
                        get_config_string(cfg, &address);
-                       if(!add_listen_address(address, true))
+
+                       if(!add_listen_address(address, true)) {
                                return false;
+                       }
                }
 
                for(config_t *cfg = lookup_config(config_tree, "ListenAddress"); cfg; cfg = lookup_config_next(config_tree, cfg)) {
                        cfgs++;
                        get_config_string(cfg, &address);
-                       if(!add_listen_address(address, false))
+
+                       if(!add_listen_address(address, false)) {
                                return false;
+                       }
                }
 
                if(!cfgs)
-                       if(!add_listen_address(address, NULL))
+                       if(!add_listen_address(address, NULL)) {
                                return false;
+                       }
        }
 
        if(!listen_sockets) {
@@ -990,20 +1151,46 @@ static bool setup_myself(void) {
 
        /* If no Port option was specified, set myport to the port used by the first listening socket. */
 
-       if(!port_specified) {
+       if(!port_specified || atoi(myport) == 0) {
                sockaddr_t sa;
-               socklen_t salen = sizeof sa;
+               socklen_t salen = sizeof(sa);
+
                if(!getsockname(listen_socket[0].udp.fd, &sa.sa, &salen)) {
                        free(myport);
                        sockaddr2str(&sa, NULL, &myport);
-                       if(!myport)
+
+                       if(!myport) {
                                myport = xstrdup("655");
+                       }
                }
        }
 
        xasprintf(&myself->hostname, "MYSELF port %s", myport);
        myself->connection->hostname = xstrdup(myself->hostname);
 
+       char *upnp = NULL;
+       get_config_string(lookup_config(config_tree, "UPnP"), &upnp);
+       bool upnp_tcp = false;
+       bool upnp_udp = false;
+
+       if(upnp) {
+               if(!strcasecmp(upnp, "yes")) {
+                       upnp_tcp = upnp_udp = true;
+               } else if(!strcasecmp(upnp, "udponly")) {
+                       upnp_udp = true;
+               }
+
+               free(upnp);
+       }
+
+       if(upnp_tcp || upnp_udp) {
+#ifdef HAVE_MINIUPNPC
+               upnp_init(upnp_tcp, upnp_udp);
+#else
+               logger(DEBUG_ALWAYS, LOG_WARNING, "UPnP was requested, but tinc isn't built with miniupnpc support!");
+#endif
+       }
+
        /* Done. */
 
        last_config_check = now.tv_sec;
@@ -1025,35 +1212,33 @@ bool setup_network(void) {
                if(pinginterval < 1) {
                        pinginterval = 86400;
                }
-       } else
+       } else {
                pinginterval = 60;
+       }
 
-       if(!get_config_int(lookup_config(config_tree, "PingTimeout"), &pingtimeout))
+       if(!get_config_int(lookup_config(config_tree, "PingTimeout"), &pingtimeout)) {
                pingtimeout = 5;
-       if(pingtimeout < 1 || pingtimeout > pinginterval)
+       }
+
+       if(pingtimeout < 1 || pingtimeout > pinginterval) {
                pingtimeout = pinginterval;
+       }
 
-       if(!get_config_int(lookup_config(config_tree, "MaxOutputBufferSize"), &maxoutbufsize))
+       if(!get_config_int(lookup_config(config_tree, "MaxOutputBufferSize"), &maxoutbufsize)) {
                maxoutbufsize = 10 * MTU;
+       }
 
-       if(!setup_myself())
+       if(!setup_myself()) {
                return false;
+       }
 
-       if(!init_control())
+       if(!init_control()) {
                return false;
+       }
 
-       /* Run tinc-up script to further initialize the tap interface */
-
-       char *envp[5] = {NULL};
-       xasprintf(&envp[0], "NETNAME=%s", netname ? : "");
-       xasprintf(&envp[1], "DEVICE=%s", device ? : "");
-       xasprintf(&envp[2], "INTERFACE=%s", iface ? : "");
-       xasprintf(&envp[3], "NAME=%s", myself->name);
-
-       execute_script("tinc-up", envp);
-
-       for(int i = 0; i < 4; i++)
-               free(envp[i]);
+       if(!device_standby) {
+               device_enable();
+       }
 
        /* Run subnet-up scripts for our own subnets */
 
@@ -1069,20 +1254,23 @@ void close_network_connections(void) {
        for(list_node_t *node = connection_list->head, *next; node; node = next) {
                next = node->next;
                connection_t *c = node->data;
+
                /* Keep control connections open until the end, so they know when we really terminated */
-               if(c->status.control)
+               if(c->status.control) {
                        c->socket = -1;
+               }
+
                c->outgoing = NULL;
                terminate_connection(c, false);
        }
 
-       if(outgoing_list)
+       if(outgoing_list) {
                list_delete_list(outgoing_list);
+       }
 
        if(myself && myself->connection) {
                subnet_update(myself, NULL, false);
-               terminate_connection(myself->connection, false);
-               free_connection(myself->connection);
+               connection_del(myself->connection);
        }
 
        for(int i = 0; i < listen_sockets; i++) {
@@ -1092,28 +1280,30 @@ void close_network_connections(void) {
                close(listen_socket[i].udp.fd);
        }
 
-       char *envp[5] = {NULL};
-       xasprintf(&envp[0], "NETNAME=%s", netname ? : "");
-       xasprintf(&envp[1], "DEVICE=%s", device ? : "");
-       xasprintf(&envp[2], "INTERFACE=%s", iface ? : "");
-       xasprintf(&envp[3], "NAME=%s", myself->name);
-
        exit_requests();
        exit_edges();
        exit_subnets();
        exit_nodes();
        exit_connections();
 
-       execute_script("tinc-down", envp);
+       if(!device_standby) {
+               device_disable();
+       }
 
-       if(myport) free(myport);
+       free(myport);
 
-       for(int i = 0; i < 4; i++)
-               free(envp[i]);
+       if(device_fd >= 0) {
+               io_del(&device_io);
+       }
 
-       devops.close();
+       if(devops.close) {
+               devops.close();
+       }
 
        exit_control();
 
+       free(scriptextension);
+       free(scriptinterpreter);
+
        return;
 }