Free resources in rsa_t.

[tinc] / src / gcrypt / rsa.c

diff --git a/src/gcrypt/rsa.c b/src/gcrypt/rsa.c
index 6530162..e38b50b 100644 (file)
--- a/src/gcrypt/rsa.c
+++ b/src/gcrypt/rsa.c
@@ -12,11 +12,9 @@
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
     GNU General Public License for more details.
 
-    You should have received a copy of the GNU General Public License
-    along with this program; if not, write to the Free Software
-    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
-
-    $Id$
+    You should have received a copy of the GNU General Public License along
+    with this program; if not, write to the Free Software Foundation, Inc.,
+    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */
 
 #include "system.h"
@@ -186,10 +184,10 @@ bool rsa_set_hex_public_key(rsa_t *rsa, char *n, char *e) {
        gcry_error_t err = 0;
 
        err = gcry_mpi_scan(&rsa->n, GCRYMPI_FMT_HEX, n, 0, NULL)
-               ?: gcry_mpi_scan(&rsa->e, GCRYMPI_FMT_HEX, n, 0, NULL);
+               ?: gcry_mpi_scan(&rsa->e, GCRYMPI_FMT_HEX, e, 0, NULL);
 
        if(err) {
-               logger(LOG_ERR, _("Error while reading RSA public key: %s"), gcry_strerror(errno));
+               logger(LOG_ERR, "Error while reading RSA public key: %s", gcry_strerror(errno));
                return false;
        }
 
@@ -200,11 +198,11 @@ bool rsa_set_hex_private_key(rsa_t *rsa, char *n, char *e, char *d) {
        gcry_error_t err = 0;
 
        err = gcry_mpi_scan(&rsa->n, GCRYMPI_FMT_HEX, n, 0, NULL)
-               ?: gcry_mpi_scan(&rsa->e, GCRYMPI_FMT_HEX, n, 0, NULL)
-               ?: gcry_mpi_scan(&rsa->d, GCRYMPI_FMT_HEX, n, 0, NULL);
+               ?: gcry_mpi_scan(&rsa->e, GCRYMPI_FMT_HEX, e, 0, NULL)
+               ?: gcry_mpi_scan(&rsa->d, GCRYMPI_FMT_HEX, d, 0, NULL);
 
        if(err) {
-               logger(LOG_ERR, _("Error while reading RSA public key: %s"), gcry_strerror(errno));
+               logger(LOG_ERR, "Error while reading RSA public key: %s", gcry_strerror(errno));
                return false;
        }
 
@@ -218,7 +216,7 @@ bool rsa_read_pem_public_key(rsa_t *rsa, FILE *fp) {
        size_t derlen;
 
        if(!pem_decode(fp, "RSA PUBLIC KEY", derbuf, sizeof derbuf, &derlen)) {
-               logger(LOG_ERR, _("Unable to read RSA public key: %s"), strerror(errno));
+               logger(LOG_ERR, "Unable to read RSA public key: %s", strerror(errno));
                return NULL;
        }
 
@@ -226,7 +224,7 @@ bool rsa_read_pem_public_key(rsa_t *rsa, FILE *fp) {
                        || !ber_read_mpi(&derp, &derlen, &rsa->n)
                        || !ber_read_mpi(&derp, &derlen, &rsa->e)
                        || derlen) {
-               logger(LOG_ERR, _("Error while decoding RSA public key"));
+               logger(LOG_ERR, "Error while decoding RSA public key");
                return NULL;
        }
 
@@ -238,7 +236,7 @@ bool rsa_read_pem_private_key(rsa_t *rsa, FILE *fp) {
        size_t derlen;
 
        if(!pem_decode(fp, "RSA PRIVATE KEY", derbuf, sizeof derbuf, &derlen)) {
-               logger(LOG_ERR, _("Unable to read RSA private key: %s"), strerror(errno));
+               logger(LOG_ERR, "Unable to read RSA private key: %s", strerror(errno));
                return NULL;
        }
 
@@ -253,7 +251,7 @@ bool rsa_read_pem_private_key(rsa_t *rsa, FILE *fp) {
                        || !ber_read_mpi(&derp, &derlen, NULL)
                        || !ber_read_mpi(&derp, &derlen, NULL) // u
                        || derlen) {
-               logger(LOG_ERR, _("Error while decoding RSA private key"));
+               logger(LOG_ERR, "Error while decoding RSA private key");
                return NULL;
        }
 
@@ -278,6 +276,10 @@ bool rsa_public_encrypt(rsa_t *rsa, void *in, size_t len, void *out) {
        gcry_mpi_t outmpi = gcry_mpi_new(len * 8);
        gcry_mpi_powm(outmpi, inmpi, rsa->e, rsa->n);
 
+       int pad = len - (gcry_mpi_get_nbits(outmpi) + 7) / 8;
+       while(pad--)
+               *(char *)out++ = 0;
+
        check(gcry_mpi_print(GCRYMPI_FMT_USG, out,len, NULL, outmpi));
 
        return true;
@@ -290,7 +292,17 @@ bool rsa_private_decrypt(rsa_t *rsa, void *in, size_t len, void *out) {
        gcry_mpi_t outmpi = gcry_mpi_new(len * 8);
        gcry_mpi_powm(outmpi, inmpi, rsa->d, rsa->n);
 
+       int pad = len - (gcry_mpi_get_nbits(outmpi) + 7) / 8;
+       while(pad--)
+               *(char *)out++ = 0;
+
        check(gcry_mpi_print(GCRYMPI_FMT_USG, out,len, NULL, outmpi));
 
        return true;
 }
+
+void rsa_free(rsa_t *rsa) {
+       gcry_mpi_release(rsa->n);
+       gcry_mpi_release(rsa->e);
+       gcry_mpi_release(rsa->d);
+}