Set FD_CLOEXEC flag on all sockets.

[tinc] / src / conf.c

diff --git a/src/conf.c b/src/conf.c
index 1b8213c..1560541 100644 (file)
--- a/src/conf.c
+++ b/src/conf.c
@@ -3,7 +3,7 @@
     Copyright (C) 1998 Robert van der Meulen
                   1998-2005 Ivo Timmermans
                   2000-2010 Guus Sliepen <guus@tinc-vpn.org>
-                  2010 Julien Muchembled <jm@jmuchemb.eu>
+                  2010-2011 Julien Muchembled <jm@jmuchemb.eu>
                  2000 Cris van Pelt
 
     This program is free software; you can redistribute it and/or modify
@@ -26,6 +26,7 @@
 #include "avl_tree.h"
 #include "connection.h"
 #include "conf.h"
+#include "list.h"
 #include "logger.h"
 #include "netutl.h"                            /* for str2address */
 #include "protocol.h"
@@ -92,7 +93,7 @@ void config_add(avl_tree_t *config_tree, config_t *cfg) {
        avl_insert(config_tree, cfg);
 }
 
-config_t *lookup_config(avl_tree_t *config_tree, char *variable) {
+config_t *lookup_config(const avl_tree_t *config_tree, char *variable) {
        config_t cfg, *found;
 
        cfg.variable = variable;
@@ -110,7 +111,7 @@ config_t *lookup_config(avl_tree_t *config_tree, char *variable) {
        return found;
 }
 
-config_t *lookup_config_next(avl_tree_t *config_tree, const config_t *cfg) {
+config_t *lookup_config_next(const avl_tree_t *config_tree, const config_t *cfg) {
        avl_node_t *node;
        config_t *found;
 
@@ -188,7 +189,7 @@ bool get_config_address(const config_t *cfg, struct addrinfo **result) {
 }
 
 bool get_config_subnet(const config_t *cfg, subnet_t ** result) {
-       subnet_t subnet = {0};
+       subnet_t subnet = {NULL};
 
        if(!cfg)
                return false;
@@ -339,25 +340,36 @@ bool read_config_file(avl_tree_t *config_tree, const char *fname) {
 
 void read_config_options(avl_tree_t *config_tree, const char *prefix) {
        list_node_t *node, *next;
-       size_t prefix_len = strlen(prefix);
+       size_t prefix_len = prefix ? strlen(prefix) : 0;
 
        for(node = cmdline_conf->tail; node; node = next) {
-               config_t *cfg = (config_t *)node->data;
+               config_t *orig_cfg, *cfg = (config_t *)node->data;
                next = node->prev;
 
-               if(!prefix && strchr(cfg->variable, '.'))
-                       continue;
-
-               if(prefix && (strncmp(prefix, cfg->variable, prefix_len) || cfg->variable[prefix_len] != '.'))
-                       continue;
-
+               if(!prefix) {
+                       if(strchr(cfg->variable, '.'))
+                               continue;
+                       node->data = NULL;
+                       list_unlink_node(cmdline_conf, node);
+               } else {
+                       if(strncmp(prefix, cfg->variable, prefix_len) ||
+                          cfg->variable[prefix_len] != '.')
+                               continue;
+                       /* Because host configuration is parsed again when
+                          reconnecting, nodes must not be freed when a prefix
+                          is given. */
+                       orig_cfg = cfg;
+                       cfg = new_config();
+                       cfg->variable = xstrdup(orig_cfg->variable + prefix_len + 1);
+                       cfg->value = xstrdup(orig_cfg->value);
+                       cfg->file = NULL;
+                       cfg->line = orig_cfg->line;
+               }
                config_add(config_tree, cfg);
-               node->data = NULL;
-               list_unlink_node(cmdline_conf, node);
        }
 }
 
-bool read_server_config() {
+bool read_server_config(void) {
        char *fname;
        bool x;