From: Etienne Dechamps <etienne@edechamps.fr>
Date: Wed, 4 Nov 2015 19:18:12 +0000 (+0000)
Subject: Revert "Cache node IDs in a hash table for faster lookups."
X-Git-Tag: release-1.1pre12~89
X-Git-Url: https://www.tinc-vpn.org/git/browse?a=commitdiff_plain;h=684bd659ae0c6ca623422851c245188037658698;hp=684bd659ae0c6ca623422851c245188037658698;p=tinc

Revert "Cache node IDs in a hash table for faster lookups."

This reverts commit c2319e90b16962fe899bc60abc8af0e2542bb176.

As a general principle, I do not believe it is worthwhile to cache
nodes. Sure, it brings lookup time down from O(log n) to O(1), but
considering that the scalability target of tinc is around 1000 nodes
and log2(1000) is 10, that looks like premature optimization; tree
lookups should already be very fast. Therefore, I believe it makes sense
to remove the cache as a code cleanup initiative.
---