X-Git-Url: https://www.tinc-vpn.org/git/browse?a=blobdiff_plain;f=src%2Fnode.c;h=8f4b6eeeb018b3c1c718b9c3fc66dd22d00f4cc9;hb=5f76bc06fba1d4ab1cfa460fff5c2695e21cabae;hp=4ec5d353d2154f95dc24b5e7b847315c9f1c45d9;hpb=70e1e467f93f885da3e49289e96757d5cd2ae5ba;p=tinc

diff --git a/src/node.c b/src/node.c
index 4ec5d353..8f4b6eee 100644
--- a/src/node.c
+++ b/src/node.c
@@ -108,17 +108,9 @@ void free_node(node_t *n) {
 
 	timeout_del(&n->udp_ping_timeout);
 
-	if(n->hostname) {
-		free(n->hostname);
-	}
-
-	if(n->name) {
-		free(n->name);
-	}
-
-	if(n->late) {
-		free(n->late);
-	}
+	free(n->hostname);
+	free(n->name);
+	free(n->late);
 
 	if(n->address_cache) {
 		close_address_cache(n->address_cache);
@@ -152,7 +144,7 @@ void node_del(node_t *n) {
 }
 
 node_t *lookup_node(char *name) {
-	node_t n = {NULL};
+	node_t n = {0};
 
 	n.name = name;
 
@@ -213,14 +205,14 @@ bool dump_nodes(connection_t *c) {
 
 		id[sizeof(id) - 1] = 0;
 		send_request(c, "%d %d %s %s %s %d %d %d %d %x %x %s %s %d %d %d %d %ld %d %"PRIu64" %"PRIu64" %"PRIu64" %"PRIu64, CONTROL, REQ_DUMP_NODES,
-		             n->name, id, n->hostname ? : "unknown port unknown",
+		             n->name, id, n->hostname ? n->hostname : "unknown port unknown",
 #ifdef DISABLE_LEGACY
 		             0, 0, 0,
 #else
 		             cipher_get_nid(n->outcipher), digest_get_nid(n->outdigest), (int)digest_length(n->outdigest),
 #endif
 		             n->outcompression, n->options, bitfield_to_int(&n->status, sizeof(n->status)),
-		             n->nexthop ? n->nexthop->name : "-", n->via ? n->via->name ? : "-" : "-", n->distance,
+		             n->nexthop ? n->nexthop->name : "-", n->via && n->via->name ? n->via->name : "-", n->distance,
 		             n->mtu, n->minmtu, n->maxmtu, (long)n->last_state_change, n->udp_ping_rtt,
 		             n->in_packets, n->in_bytes, n->out_packets, n->out_bytes);
 	}