projects
/
tinc
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Don't check for NULL-pointers before calling free().
[tinc]
/
src
/
conf.c
diff --git
a/src/conf.c
b/src/conf.c
index
4497b0e
..
58d7b6d
100644
(file)
--- a/
src/conf.c
+++ b/
src/conf.c
@@
-81,18
+81,9
@@
config_t *new_config(void) {
}
void free_config(config_t *cfg) {
}
void free_config(config_t *cfg) {
- if(cfg->variable) {
- free(cfg->variable);
- }
-
- if(cfg->value) {
- free(cfg->value);
- }
-
- if(cfg->file) {
- free(cfg->file);
- }
-
+ free(cfg->variable);
+ free(cfg->value);
+ free(cfg->file);
free(cfg);
}
free(cfg);
}
@@
-204,7
+195,7
@@
bool get_config_address(const config_t *cfg, struct addrinfo **result) {
}
bool get_config_subnet(const config_t *cfg, subnet_t **result) {
}
bool get_config_subnet(const config_t *cfg, subnet_t **result) {
- subnet_t subnet = {};
+ subnet_t subnet = {
0
};
if(!cfg) {
return false;
if(!cfg) {
return false;
@@
-432,7
+423,7
@@
bool read_server_config(void) {
// And we try to read the ones that end with ".conf"
if(l > 5 && !strcmp(".conf", & ep->d_name[ l - 5 ])) {
// And we try to read the ones that end with ".conf"
if(l > 5 && !strcmp(".conf", & ep->d_name[ l - 5 ])) {
- if(snprintf(fname, sizeof(fname), "%s/%s", dname, ep->d_name) >= sizeof(fname)) {
+ if(
(size_t)
snprintf(fname, sizeof(fname), "%s/%s", dname, ep->d_name) >= sizeof(fname)) {
logger(LOG_ERR, "Pathname too long: %s/%s", dname, ep->d_name);
return false;
}
logger(LOG_ERR, "Pathname too long: %s/%s", dname, ep->d_name);
return false;
}
@@
-578,7
+569,7
@@
FILE *ask_and_open(const char *filename, const char *what) {
/* The directory is a relative path or a filename. */
getcwd(directory, sizeof(directory));
/* The directory is a relative path or a filename. */
getcwd(directory, sizeof(directory));
- if(snprintf(abspath, sizeof(abspath), "%s/%s", directory, fn) >= sizeof(abspath)) {
+ if(
(size_t)
snprintf(abspath, sizeof(abspath), "%s/%s", directory, fn) >= sizeof(abspath)) {
fprintf(stderr, "Pathname too long: %s/%s\n", directory, fn);
return NULL;
}
fprintf(stderr, "Pathname too long: %s/%s\n", directory, fn);
return NULL;
}