tinc 1.1: missing PONG

Guus Sliepen guus at tinc-vpn.org
Tue Feb 27 21:23:49 CET 2018


On Tue, Feb 27, 2018 at 11:23:54AM -0700, Todd C. Miller wrote:

> Here's a diff to call WSAWaitForMultipleEvents() repeatedly to check
> for events other than the first one returned.  I've also added a
> map of io_t to events[] index so avoid the need for splay_search().

That's great, less changes to the tree are good.

> The value of event_count will change if a callback adds an event
> so we need to handle that.
> 
> I've added a generation number to the splay tree head that gets
> incremented by io_del().  I'm undecided whether it should also be
> incremented by io_add().

That would probably be nice to do, although the code in event.c doesn't
depend on that.

> Does this seem like the right direction?
[...diff...]

That all looks very good!

-- 
Met vriendelijke groet / with kind regards,
     Guus Sliepen <guus at tinc-vpn.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://www.tinc-vpn.org/pipermail/tinc-devel/attachments/20180227/cc296e98/attachment.sig>


More information about the tinc-devel mailing list