non-standard base64 functions in tinc 1.1

[Guus Sliepen]

On Wed, Aug 30, 2017 at 02:35:44PM -0600, Todd C. Miller wrote:

> I noticed that the base64 functions in util.c don't produce the
> same results as other versions that implement RFC 1421 (and its
> successors).  This results in PEM files that can only be decoded
> by tinc itself.
> 
> Is this intentional?

No. On the other hand, tinc's Ed25519 private keys are not actually PEM
encoded at all, it's just some raw blob encoded with base64 and
----BEGIN... and -----END... lines slapped around it, and one shouldn't
use tinc's keys for anything else.

> Below is a diff to make tinc's base64 functions match what everyone
> else does.  This will break existing key files, though, which is
> unfortunate.

I think I'll keep it the way it is for now, but thanks for pointing it
out.

-- 
Met vriendelijke groet / with kind regards,
     Guus Sliepen <guus at tinc-vpn.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://www.tinc-vpn.org/pipermail/tinc-devel/attachments/20170830/90851eac/attachment.sig>