tinc 1.1: d237efd32 "Only read one record at a time in sptps_receive_data()." breaks invite-join.test

[Sven-Haegar Koch]

Hallo,

As part of building a debian package for my use of tinc 1.1 I run the 
"make check" testsuites.

The current git breaks in invite-join.test:

FAIL: invite-join
=================

+ ../src/tinc --config=/home/haegar/tinc/tinc/test/./invite-join.test.1 
--pidfile=/home/haegar/tinc/tinc/test/./invite-join.test.1/pid
Generating 2048 bits keys:
...........................+++ p
....+++ q
Done.
Generating Ed25519 keypair:
Done.
Warning: could not bind to port 655. Tinc will instead listen on port 
36786.
+ sleep 1
+ ../src/tinc --config=/home/haegar/tinc/tinc/test/./invite-join.test.1 
--pidfile=/home/haegar/tinc/tinc/test/./invite-join.test.1/pid invite 
bar
+ ../src/tinc --config=/home/haegar/tinc/tinc/test/./invite-join.test.2 
--pidfile=/home/haegar/tinc/tinc/test/./invite-join.test.2/pid join
Connected to localhost port 32751...
Connection closed by peer, invitation cancelled.

Attached are the contents of test/invite-join.test.1/log


git bisect points to
# first bad commit: [d237efd325cd7bdd73f5eb111c769470238dce6e] Only read 
one record at a time in sptps_receive_data().


c'ya
sven-haegar


git bisect log:

(Note that some commit IDs are special to my 
git://git.sdinet.de/tinc.git tree, containing also my debian packaging)

git bisect start
# good: [a44625e07b87b24dbdad205c47f7fba319ffe6b7] tinc (1.1~pre11+git20150424-0.sdinetH1) unstable; urgency=low
git bisect good a44625e07b87b24dbdad205c47f7fba319ffe6b7
# bad: [67ad581b6b9c6dc671ef3fb16d3efe87b8a96180] tinc (1.1~pre11+git20150510-0.sdinetH1) unstable; urgency=low
git bisect bad 67ad581b6b9c6dc671ef3fb16d3efe87b8a96180
# good: [13f9bc1ff199bea46d3dde391a848f119e2cc0f0] Add support for out-of-tree ("VPATH") builds.
git bisect good 13f9bc1ff199bea46d3dde391a848f119e2cc0f0
# good: [10c1f60c643607d9dafd79271c3475cddf81e903] Try to use UDP to relay SPTPS packets received over TCP.
git bisect good 10c1f60c643607d9dafd79271c3475cddf81e903
# bad: [d237efd325cd7bdd73f5eb111c769470238dce6e] Only read one record at a time in sptps_receive_data().
git bisect bad d237efd325cd7bdd73f5eb111c769470238dce6e
# good: [de14308840a96060d700c93117789e83ec948c01] Rename REQ_SPTPS to SPTPS_PACKET.
git bisect good de14308840a96060d700c93117789e83ec948c01
# first bad commit: [d237efd325cd7bdd73f5eb111c769470238dce6e] Only read one record at a time in sptps_receive_data().

-- 
Three may keep a secret, if two of them are dead.
- Ben F.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: log.txt
URL: <http://www.tinc-vpn.org/pipermail/tinc-devel/attachments/20150513/be3b4f33/attachment.txt>