Tinc improvements

[Guus Sliepen]

On Mon, Jan 03, 2011 at 07:01:46PM +0100, Daniel Schall wrote:

> I've attached my first git commit to your repository.
> It does not contain any new functionalities, but it is a first try to
> interact with your git copy.

It applies. However, try to keep separate issues in separate commits:

> add iphlpapi and other headers to have.h and configure.in
> add flags to vpn_packet

The change to have.h and configure.in for example could be in its own commit.
Also, some more information in the commit message, such as why you want to link
with iphlpapi or what flags you add, would be helpful.

Also, it is better to send patches with "git send-email <previous-commit>",
where <previous-commit> can be a commit ID or an alias like "HEAD^^", and this
will format all the commits after the specified one and email them, such that I
can just pipe the mails through "git am". 

Alternatively, make your git tree publicly accessible, so that I can just pull
from it. Perhaps I can set something up on tinc-vpn.org where people can push
into their own branches...

Anyway, I cannot accept this commit, the added flags to vpn_packet make it
incompatible with previous versions, and there is no fallback option.

> 1) some small improvements in logging
> 	(using flags instead of counters)
> 
> 2) the multicast announcement stuff we talked about in the last months

That would be great.

> 3) an improved PMTU discovery with predictable packet sizes for the
> probe packets

Hm, that is probably a bad idea, but it depends on how you do it exactly.

> By the way, I've re-formatted the code to better suit your coding style.

Great :)

-- 
Met vriendelijke groet / with kind regards,
     Guus Sliepen <guus at tinc-vpn.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://www.tinc-vpn.org/pipermail/tinc-devel/attachments/20110105/6647c9e4/attachment.pgp>